Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change example in doc/bordeaux/elliptic_curves.rst #12184

Closed
JohnCremona opened this issue Dec 18, 2011 · 8 comments
Closed

Change example in doc/bordeaux/elliptic_curves.rst #12184

JohnCremona opened this issue Dec 18, 2011 · 8 comments

Comments

@JohnCremona
Copy link
Member

In William Stein's Bordeaux lectures he gave an example of an elliptic curve not in the tables (of conductor 154907). But as of version 4.8 that curve is in the tables in the optional larger database, and so that example causes a doctest failure in sage/doc/en/bordeaux/elliptic_curves.rst.

The patch changes the example to one whose conductor is larger.

To test: apply the patch and test sage/doc/en/bordeaux/elliptic_curves.rst both before and after installing the optional package at #11587 (i.e. http://wstein.org/home/ohanar/cremona-database/database_cremona_ellcurve-20111029.spkg).

CC: @williamstein

Component: documentation

Keywords: rd2

Reviewer: R. Andrew Ohana

Issue created by migration from https://trac.sagemath.org/ticket/12184

@JohnCremona
Copy link
Member Author

Apply to 4.8 (e.g. 4.8.alpha4)

@JohnCremona
Copy link
Member Author

comment:1

Attachment: trac_12184-ex.patch.gz

@JohnCremona

This comment has been minimized.

@jbalakrishnan
Copy link

comment:2

This is a near-duplicate of #12617, so we should close this ticket in favor of that one.

@jbalakrishnan jbalakrishnan removed this from the sage-5.0 milestone Mar 17, 2012
@jbalakrishnan
Copy link

Changed keywords from none to rd2

@ohanar
Copy link
Member

ohanar commented Mar 18, 2012

comment:4

sounds good

@ohanar
Copy link
Member

ohanar commented Mar 18, 2012

Reviewer: R. Andrew Ohana

@jdemeyer
Copy link

Changed author from John Cremona to none

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants