Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix upgrading of root repository #12324

Closed
jhpalmieri opened this issue Jan 18, 2012 · 8 comments
Closed

Fix upgrading of root repository #12324

jhpalmieri opened this issue Jan 18, 2012 · 8 comments

Comments

@jhpalmieri
Copy link
Member

On sage-devel, there are occasional complaints about the failure to upgrade because of uncommitted files in the root repository. We should address these. The culprit is in the script sage-update, and in particular the lines

    if root_repo_intact:
        P = subprocess.Popen('hg status', shell=True,
                             stdout=subprocess.PIPE)
        output = P.communicate()[0]
        if len(output) > 0: # uncommitted changes
            print ("There are uncommitted changes in the "
                   + "Sage root repository. Aborting.")
            sys.exit(2)

Apply attachment: 12324_status_q.patch to the scripts repository.

CC: @kini

Component: scripts

Keywords: root upgrade

Author: Jeroen Demeyer

Reviewer: John Palmieri

Merged: sage-5.3.rc1

Issue created by migration from https://trac.sagemath.org/ticket/12324

@jdemeyer
Copy link

Attachment: 12324_status_q.patch.gz

@jdemeyer
Copy link

Author: Jeroen Demeyer

@jdemeyer
Copy link

comment:1

"critical" because this annoys me terribly.

@jdemeyer

This comment has been minimized.

@jdemeyer

This comment has been minimized.

@jhpalmieri
Copy link
Member Author

Reviewer: John Palmieri

@jhpalmieri
Copy link
Member Author

comment:4

Looks okay to me. It allows upgrading when there are stray files in the root repo.

@jdemeyer
Copy link

jdemeyer commented Sep 2, 2012

Merged: sage-5.3.rc1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants