Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Doctest for sage.categories.category.__repr_object_names fails interactively #12383

Closed
roed314 opened this issue Jan 29, 2012 · 7 comments
Closed

Doctest for sage.categories.category.__repr_object_names fails interactively #12383

roed314 opened this issue Jan 29, 2012 · 7 comments
Assignees
@nthiery
Labels
c: categories p: minor / 4 t: bug
Milestone
sage-5.1

Comments

@roed314
Copy link
Contributor

roed314 commented Jan 29, 2012

The following fails at the command line (rather than in sage -t, where it succeeds)

sage: Rings().__repr_object_names
BOOM!

Component: categories

Keywords: sd40.5

Author: David Roe

Reviewer: Dan Drake

Merged: sage-5.1.beta2

Issue created by migration from https://trac.sagemath.org/ticket/12383
@roed314 roed314 added this to the sage-5.1 milestone Jan 29, 2012
@roed314
Copy link
Contributor Author

roed314 commented Jan 29, 2012

Attachment: 12383.patch.gz

@nthiery
Copy link
Contributor

nthiery commented Jan 29, 2012

comment:2

Hi David!

Thanks for the fix. I am just don't understand how comes those tests did pass before? Which version are you applying this patch onto?

@roed314
Copy link
Contributor Author

roed314 commented Jan 30, 2012

comment:3

Sorry. This is against sage-5.0.beta1, and the patch fails to apply to sage-4.8. I don't understand why the doctest was succeeding earlier, but sage -t succeeded on my build of sage-5.0.beta1 on sage.math.

@dandrake
Copy link
Contributor

comment:4

This applies cleanly to 5.1.beta0 and fixes the interactive problem. Positive review.

@dandrake
Copy link
Contributor

Reviewer: Dan Drake

@dandrake
Copy link
Contributor

Changed keywords from none to sd40.5

@jdemeyer
Copy link

jdemeyer commented Jun 2, 2012

Merged: sage-5.1.beta2

@jdemeyer jdemeyer closed this as completed Jun 2, 2012
@robertwb robertwb mentioned this issue Jun 15, 2013
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nthiery nthiery

Labels
c: categories p: minor / 4 t: bug
Projects
None yet
Milestone
sage-5.1
Development

No branches or pull requests
4 participants
@roed314 @nthiery @dandrake @jdemeyer