New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
factorization of 0 in GF(p)[x,y] fails #12419
Comments
comment:5
works now (sage 9.5.b0):
|
comment:6
it works already in Sage 9.1. I propose to resolve as "fixed". |
comment:7
somebody(?) should add a doctest, no ? |
comment:8
I can do it, but it's a long time I didn't contribute to Sage. Is there a howto somewhere? |
comment:9
humm, if you know git, this is simple. Otherwise, c'est moins simple. there is the big developer manual, and in particular https://doc.sagemath.org/html/en/developer/index.html#git-tricks-tips in very short : (1) clone the git repo and go to the develop branch (2) set the remote to trac (3) make a local branch on top of the develop branch (4) push the branch to trac under u/your_trac_name/branch_name (5) write that branch name in the ticket branch field |
comment:10
thanks, I've added a doctest, now running sage -t -all |
comment:11
si la branche est prete, le patchbot peut se charger de lancer les tests. |
comment:12
I get the following error while running the tests:
|
comment:13
merci de pousser la branche sur trac, et d'écrire son nom dans le champ "branch" ci-dessus. On fera faire les tests par un patchbot. |
comment:14
it seems I don't have the right to push to trac (or I did the wrong command):
|
comment:15
my remote says
Tro to use simply
EDIT: should use zimmerma, your user name here |
comment:17
thanks, it works! The branch is called For the record, what I did:
|
Commit: |
Branch: u/zimmerma/12419 |
comment:18
I have put the branch name in place New commits:
|
Author: Paul Zimmermann |
comment:19
branch looks good. A patchbot should come, if not I will launch mine when it becomes available. |
comment:20
ok, green bot |
Reviewer: Frédéric Chapoton |
comment:21
Merge conflict |
Changed branch from u/zimmerma/12419 to u/chapoton/12419 |
comment:23
rebased New commits:
|
comment:24
back to positive |
comment:25
I don't have time to test, but the original failure was for 0 not 1 if I remember correctly. Does it work for 0 too? |
comment:26
sorry, the factorization of 0 is not defined. For 1 it works already in 9.4. |
Changed branch from u/chapoton/12419 to |
This was reported by Charles Bouillaguet.
Paul Zimmermann
Component: factorization
Author: Paul Zimmermann
Branch/Commit:
c7e7d54
Reviewer: Frédéric Chapoton
Issue created by migration from https://trac.sagemath.org/ticket/12419
The text was updated successfully, but these errors were encountered: