Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to take numeric powers of I #12511

Closed
robertwb opened this issue Feb 15, 2012 · 12 comments
Closed

Unable to take numeric powers of I #12511

robertwb opened this issue Feb 15, 2012 · 12 comments

Comments

@robertwb
Copy link
Contributor

sage: I ^ 0.5
None

Apply attachment: 12511-I-pow.fixed.patch to $SAGE_ROOT/devel/sage-main

CC: @williamstein

Component: symbolics

Author: Robert Bradshaw

Reviewer: Burcin Erocal

Merged: sage-5.0.beta5

Issue created by migration from https://trac.sagemath.org/ticket/12511

@robertwb robertwb added this to the sage-5.0 milestone Feb 15, 2012
@robertwb
Copy link
Contributor Author

comment:1

Attachment: 12511-I-pow.patch.gz

@robertwb
Copy link
Contributor Author

comment:3

FYI, I changed "return None" to raise an error to avoid (and make more debuggable) future issues of this sort. For places where None is explicitly acceptable (in the bowels of Pynac) it can be returned explicitly in the except clause.

@a-andre
Copy link

a-andre commented Feb 15, 2012

comment:4

Use the Python 3 compatible syntax to raise an error

raise ValueError("recursion")

@burcin
Copy link

burcin commented Feb 15, 2012

comment:5

Thanks for the quick fix!

@burcin
Copy link

burcin commented Feb 15, 2012

Reviewer: Burcin Erocal

@kini

This comment has been minimized.

@kini
Copy link
Contributor

kini commented Feb 15, 2012

comment:6

Burcin, I trust this fix doesn't cancel your positive review?

@burcin
Copy link

burcin commented Feb 15, 2012

comment:7

Replying to @kini:

Burcin, I trust this fix doesn't cancel your positive review?

Good catch! Still positive review. :)

@kini
Copy link
Contributor

kini commented Feb 15, 2012

comment:8

Replying to @burcin:

Good catch!

aapitzsch is the one who caught it, I just fixed it :)

@jdemeyer
Copy link

Rebased to sage-5.0.beta4, apply only this

@jdemeyer
Copy link

comment:9

Attachment: 12511-I-pow.fixed.patch.gz

@jdemeyer
Copy link

Merged: sage-5.0.beta5

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants