Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed point and periodic point of word morphism #12512

Closed
videlec opened this issue Feb 15, 2012 · 9 comments
Closed

fixed point and periodic point of word morphism #12512

videlec opened this issue Feb 15, 2012 · 9 comments

Comments

@videlec
Copy link
Contributor

videlec commented Feb 15, 2012

This ticket is motivated by #12454. The aim is to implement new functionalities for word morphism (in sage.combinat.words.morphism) for computing individual as well as list of fixed point and periodic points.

CC: @sagetrac-tjolivet

Component: combinatorics

Keywords: word morphism

Author: Vincent Delecroix

Reviewer: Timo Jolivet

Merged: sage-5.0.beta10

Issue created by migration from https://trac.sagemath.org/ticket/12512

@videlec videlec added this to the sage-5.0 milestone Feb 15, 2012
@videlec videlec self-assigned this Feb 15, 2012
@loefflerd
Copy link
Mannequin

loefflerd mannequin commented Mar 13, 2012

comment:2

There is a typo "dictionnary" at line 99, and a rogue non-ASCII character at line 130. At line 131, f.domain should be in double backticks and "try" --> "tries".

@sagetrac-tjolivet
Copy link
Mannequin

sagetrac-tjolivet mannequin commented Mar 13, 2012

comment:4

Hi,

The patch applies well, the doc builds fine, the tests pass and the previous comments have been taken into account.

This is a very nice and useful patch, thank you.

You could add an example of a morphism without fixed points but with periodic points, for example:

sage: f = WordMorphism('a->b,b->c,c->ab') 
sage: f.fixed_points()                    
[]
sage: f.periodic_points()                 
[[word: abbcbccabbccabcababbcbccabcababbccababbc..., word: bccabcababbccababbcabbcbccabcababbcabbcb..., word: cababbcabbcbccababbcbccabbccabcababbcabb...]]

@sagetrac-tjolivet
Copy link
Mannequin

sagetrac-tjolivet mannequin commented Mar 13, 2012

Reviewer: tjolivet

@videlec
Copy link
Contributor Author

videlec commented Mar 13, 2012

comment:6

Hi Timo!

Actually there is yet such an example in the documentation of periodic_points a->bab, b->aa.

Vincent

@sagetrac-tjolivet
Copy link
Mannequin

sagetrac-tjolivet mannequin commented Mar 13, 2012

comment:7

Oups, my bad, sorry!

@jdemeyer
Copy link

Changed author from vdelecroix to Vincent Delecroix

@jdemeyer
Copy link

Changed reviewer from tjolivet to Timo Jolivet

@jdemeyer
Copy link

comment:9

Attachment: trac_12512-periodic_point.patch.gz

Fixed commit message (removed the "trac 12512" line)

@jdemeyer
Copy link

Merged: sage-5.0.beta10

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants