New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add interface for PALP polytope databases #12553
Comments
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
comment:4
I've updated the patches with various minor improvements. |
comment:5
I had a look and have some remarks to do:
|
comment:6
I've added the shebang to the build.sh scripts, even though we are entering deep into bikeshedding territory here as these are not executed but only show how the database can be built. I've also renamed the directory to All databases in Sage just copy their content. Usually they require non-trivial computer resources to build, so you specifically don't want to recompute them when you are installing Sage. In this case its actually computationally easy, but just wait until we add the 4-d case ;-) |
comment:7
Copying the contents is ok -- what bothers me is that you copy the scripts too. You says that "these are not executed but only show how the database can be built" -- does that mean you don't guarantee they effectively work? |
comment:8
Well you have my word that the scripts work :-P I think having the scripts is better than not having them. Who cares if they end up in the database directory or not. |
comment:9
I see two reasons to care:
|
comment:10
Lets call it documentation, then, shall we? |
comment:11
If it's documentation, it belongs into SAGE_DOC ; installing things in correct places isn't as frivolous as you seem to think... |
comment:12
|
comment:13
Why not just cp the right files into $SAGE_DATA? |
comment:14
I've deleted the build.sh scripts. Updated spkg at the same location. |
comment:15
Updating the database patch for the new |
Updated patch |
Attachment: trac_12553_palp_database.patch.gz Rediffed patch |
comment:16
Attachment: trac_12553_ppl_count_points.patch.gz can this ticket be rebased so that it does not depend upon anything that is in |
comment:17
I think Jeroen just used sage-pending in #11310 since we didn't have a sage-5.3 milestone at that time and sage-5.2 is supposed to be just a new sagenb + trivial tickets. But maybe Jeroen had some other reason? |
comment:19
Hi Volker, do you actually have the package for 4d polytopes which is mentioned in the patch documentation? (By the way, maybe |
comment:20
Sorry forgot to reply.. I haven't packaged the 4d database... 10 GB spkg? ;-) But the updated spkg contains the 2d and 3d analogues in PALP's binary database format. |
comment:21
somewhere down in the first patch you have
but this does not work. Was it meant to be added later? |
comment:22
Yes. Though there is also the question whether we want to host a 4+gb database (and I don't have a firm opinion either way) |
comment:23
For fun: http://boxen.math.washington.edu/home/vbraun/www/polytopes_db_4d-1.0.spkg Still takes a day or so to upload... |
comment:24
Replying to @vbraun:
IMHO, if it is hosted elsewhere, we might rather want to host an interface only. |
This comment has been minimized.
This comment has been minimized.
comment:25
Updated |
comment:26
I made a ticket for the 4-d database at #14467. |
comment:27
Replying to @vbraun:
This spkg can only be found on |
comment:28
I'm leaving Ireland and my DIAS account will be closed in the coming weeks. I uploaded the spkg to boxen, and this is where it should be. The link in the ticket description works for me. |
comment:29
Replying to @vbraun:
Wohin, Volker? |
Attachment: trac_12553_ppl_lattice_polytope.patch.gz Updated patch |
Reviewer: Dmitrii Pasechnik |
Merged: sage-5.10.beta2 |
This ticket implements an interface to read databases of reflexive polytopes:
polytopes_db.spkg
.PALPreader
that can read the palp output and yield it in various Sage representations.The updated polytopes spkg is here:
http://boxen.math.washington.edu/home/vbraun/spkg/polytopes_db-20120220.spkg
Apply:
Depends on #11763
Depends on #11634
Depends on #12544
Depends on #14467
CC: @novoselt @jdemeyer
Component: packages: huge
Keywords: PALP reflexive polytopes
Author: Volker Braun
Reviewer: Dmitrii Pasechnik
Merged: sage-5.10.beta2
Issue created by migration from https://trac.sagemath.org/ticket/12553
The text was updated successfully, but these errors were encountered: