Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add interface for PALP polytope databases #12553

Closed
vbraun opened this issue Feb 21, 2012 · 37 comments
Closed

Add interface for PALP polytope databases #12553

vbraun opened this issue Feb 21, 2012 · 37 comments

Comments

@vbraun
Copy link
Member

vbraun commented Feb 21, 2012

This ticket implements an interface to read databases of reflexive polytopes:

  • Add databases in PALP format to the polytopes_db.spkg.
  • A class PALPreader that can read the palp output and yield it in various Sage representations.
  • Finally, this ticket contains a specialized PPL lattice polytope that is fast enough to construct to go through the 500 million 4-d reflexive polytopes and compute integral points.

The updated polytopes spkg is here:
http://boxen.math.washington.edu/home/vbraun/spkg/polytopes_db-20120220.spkg

Apply:

Depends on #11763
Depends on #11634
Depends on #12544
Depends on #14467

CC: @novoselt @jdemeyer

Component: packages: huge

Keywords: PALP reflexive polytopes

Author: Volker Braun

Reviewer: Dmitrii Pasechnik

Merged: sage-5.10.beta2

Issue created by migration from https://trac.sagemath.org/ticket/12553

@vbraun

This comment has been minimized.

@vbraun

This comment has been minimized.

@vbraun
Copy link
Member Author

vbraun commented Feb 21, 2012

Dependencies: #11763, #11634

@vbraun
Copy link
Member Author

vbraun commented Jun 3, 2012

comment:4

I've updated the patches with various minor improvements.

@SnarkBoojum
Copy link
Mannequin

SnarkBoojum mannequin commented Jun 11, 2012

comment:5

I had a look and have some remarks to do:

  • now spkg-install checks for SAGE_DATA before using SAGE_DATA (the one in sage 5.0 checks SAGE_ROOT before using SAGE_DATA...), which is good!
  • the sources aren't in a directory src/ but in reflexive_polytopes/ -- isn't it against the conventions?
  • both build.sh scripts lack a shebang ;
  • is it normal that the installation is dumping everything in SAGE_DATA/reflexive_polytopes/ ? Shouldn't the spkg (1) depend on palp (2) in the build phase, use it to create the database (3) in the install phase, only install the resulting database?

@vbraun
Copy link
Member Author

vbraun commented Jun 11, 2012

comment:6

I've added the shebang to the build.sh scripts, even though we are entering deep into bikeshedding territory here as these are not executed but only show how the database can be built.

I've also renamed the directory to src/, thats just something I inherited from the previous version.

All databases in Sage just copy their content. Usually they require non-trivial computer resources to build, so you specifically don't want to recompute them when you are installing Sage. In this case its actually computationally easy, but just wait until we add the 4-d case ;-)

@SnarkBoojum
Copy link
Mannequin

SnarkBoojum mannequin commented Jun 11, 2012

comment:7

Copying the contents is ok -- what bothers me is that you copy the scripts too.

You says that "these are not executed but only show how the database can be built" -- does that mean you don't guarantee they effectively work?

@vbraun
Copy link
Member Author

vbraun commented Jun 11, 2012

comment:8

Well you have my word that the scripts work :-P I think having the scripts is better than not having them. Who cares if they end up in the database directory or not.

@SnarkBoojum
Copy link
Mannequin

SnarkBoojum mannequin commented Jun 11, 2012

comment:9

I see two reasons to care:

  1. sage is big enough ;
  2. if it's not data, it doesn't belong to SAGE_DATA.

@vbraun
Copy link
Member Author

vbraun commented Jun 11, 2012

comment:10

Lets call it documentation, then, shall we?

@SnarkBoojum
Copy link
Mannequin

SnarkBoojum mannequin commented Jun 11, 2012

comment:11

If it's documentation, it belongs into SAGE_DOC ; installing things in correct places isn't as frivolous as you seem to think...

@vbraun
Copy link
Member Author

vbraun commented Jun 12, 2012

comment:12

$SAGE_DOC contains docs like the developer manual. You want me to typeset the script in sphinx and include it in the developer manual? That doesn't sound reasonable to me.

@SnarkBoojum
Copy link
Mannequin

SnarkBoojum mannequin commented Jun 12, 2012

comment:13

Why not just cp the right files into $SAGE_DATA?

@vbraun
Copy link
Member Author

vbraun commented Jun 12, 2012

comment:14

I've deleted the build.sh scripts. Updated spkg at the same location.

@vbraun
Copy link
Member Author

vbraun commented Jul 1, 2012

comment:15

Updating the database patch for the new PointCollection output introduced in #12544, which is one of the possible output formats.

@vbraun
Copy link
Member Author

vbraun commented Jul 1, 2012

Changed dependencies from #11763, #11634 to #11763, #11634, #12544

@vbraun
Copy link
Member Author

vbraun commented Jul 1, 2012

Updated patch

@vbraun
Copy link
Member Author

vbraun commented Jul 2, 2012

Attachment: trac_12553_palp_database.patch.gz

Rediffed patch

@dimpase
Copy link
Member

dimpase commented Jul 9, 2012

comment:16

Attachment: trac_12553_ppl_count_points.patch.gz

can this ticket be rebased so that it does not depend upon anything that is in sage-pending, such as #11310 ?

@vbraun
Copy link
Member Author

vbraun commented Jul 9, 2012

comment:17

I think Jeroen just used sage-pending in #11310 since we didn't have a sage-5.3 milestone at that time and sage-5.2 is supposed to be just a new sagenb + trivial tickets. But maybe Jeroen had some other reason?

@jdemeyer
Copy link

jdemeyer commented Jul 9, 2012

comment:18

It's mainly because of #13109. The current plan is to merge #13109 in sage-5.2 but all follow-ups (including #11310) in sage-5.3. It's certainly not meant to be a long-term sage-pending.

@novoselt
Copy link
Member

comment:19

Hi Volker, do you actually have the package for 4d polytopes which is mentioned in the patch documentation?

(By the way, maybe polytopes_reflexive_4d_db would be a better name for it?)

@vbraun
Copy link
Member Author

vbraun commented Aug 4, 2012

comment:20

Sorry forgot to reply.. I haven't packaged the 4d database... 10 GB spkg? ;-) But the updated spkg contains the 2d and 3d analogues in PALP's binary database format.

@dimpase
Copy link
Member

dimpase commented Apr 17, 2013

comment:21

somewhere down in the first patch you have

The database is very large and not installed by default. You can 
install it with the command ``install_package('polytopes_db_4d')``.

but this does not work. Was it meant to be added later?

@vbraun
Copy link
Member Author

vbraun commented Apr 17, 2013

comment:22

Yes. Though there is also the question whether we want to host a 4+gb database (and I don't have a firm opinion either way)

@vbraun
Copy link
Member Author

vbraun commented Apr 17, 2013

comment:23

For fun: http://boxen.math.washington.edu/home/vbraun/www/polytopes_db_4d-1.0.spkg

Still takes a day or so to upload...

@dimpase
Copy link
Member

dimpase commented Apr 18, 2013

comment:24

Replying to @vbraun:

Yes. Though there is also the question whether we want to host a 4+gb database (and I don't have a firm opinion either way)

IMHO, if it is hosted elsewhere, we might rather want to host an interface only.
Anyhow that comment in the source about install_package('polytopes_db_4d') is misleading, and should be rectified.

@vbraun

This comment has been minimized.

@vbraun
Copy link
Member Author

vbraun commented Apr 20, 2013

comment:25

Updated polytopes_db-20120220.spkg to merge in the changes that others have done in the year+ that it has been lingering here.

@vbraun
Copy link
Member Author

vbraun commented Apr 20, 2013

Changed dependencies from #11763, #11634, #12544 to #11763, #11634, #12544, #14467

@vbraun
Copy link
Member Author

vbraun commented Apr 20, 2013

comment:26

I made a ticket for the 4-d database at #14467.

@dimpase
Copy link
Member

dimpase commented Apr 22, 2013

comment:27

Replying to @vbraun:

Updated polytopes_db-20120220.spkg to merge in the changes that others have done in the year+ that it has been lingering here.

This spkg can only be found on http://www.stp.dias.ie/~vbraun/Sage/spkg/.
Is this how this is meant to be?

@vbraun
Copy link
Member Author

vbraun commented Apr 22, 2013

comment:28

I'm leaving Ireland and my DIAS account will be closed in the coming weeks. I uploaded the spkg to boxen, and this is where it should be. The link in the ticket description works for me.

@dimpase
Copy link
Member

dimpase commented Apr 25, 2013

comment:29

Replying to @vbraun:

I'm leaving Ireland and my DIAS account will be closed in the coming weeks. I uploaded the spkg to boxen, and this is where it should be. The link in the ticket description works for me.

Wohin, Volker?

@jdemeyer jdemeyer removed this from the sage-5.10 milestone Apr 29, 2013
@vbraun
Copy link
Member Author

vbraun commented May 5, 2013

Attachment: trac_12553_ppl_lattice_polytope.patch.gz

Updated patch

@jdemeyer
Copy link

jdemeyer commented May 7, 2013

Reviewer: Dmitrii Pasechnik

@jdemeyer jdemeyer added this to the sage-5.10 milestone May 7, 2013
@jdemeyer jdemeyer removed the pending label May 7, 2013
@jdemeyer
Copy link

jdemeyer commented May 8, 2013

Merged: sage-5.10.beta2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants