Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't "import site" in sympy's installer #12563

Closed
jdemeyer opened this issue Feb 22, 2012 · 7 comments
Closed

Don't "import site" in sympy's installer #12563

jdemeyer opened this issue Feb 22, 2012 · 7 comments

Comments

@jdemeyer
Copy link

Since #12329, sympy might be installed after the Sage library. The sympy setup.py imports lots of stuff, including sage itself. This is obviously not good, since not all of Sage has been built. Possible consequences include segmentation faults or sage-cleaner being started.

The solution is to start setup.py with python's -S option to start Python with a minimal sys.path.

spkg: http://boxen.math.washington.edu/home/jdemeyer/spkg/sympy-0.7.1.p0.spkg

Component: packages: standard

Author: Jeroen Demeyer

Reviewer: William Stein

Merged: sage-5.0.beta6

Issue created by migration from https://trac.sagemath.org/ticket/12563

@jdemeyer

This comment has been minimized.

@jdemeyer
Copy link
Author

Attachment: sympy-0.7.1.p0.diff.gz

Diff for the sympy spkg, for review only

@jdemeyer

This comment has been minimized.

@williamstein
Copy link
Contributor

comment:4

Instead of a comment that sagelocal is defined, why not check it and exit with an error if it is not defined?

@jdemeyer
Copy link
Author

comment:5

Replying to @williamstein:

Instead of a comment that sagelocal is defined, why not check it and exit with an error if it is not defined?

That's precisely what's happening in lines 3--7 of spkg-install.

@jdemeyer
Copy link
Author

Reviewer: William Stein

@jdemeyer
Copy link
Author

Merged: sage-5.0.beta6

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants