Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error in creating a Permutation Group #12597

Closed
dkrenn opened this issue Feb 26, 2012 · 6 comments
Closed

Error in creating a Permutation Group #12597

dkrenn opened this issue Feb 26, 2012 · 6 comments

Comments

@dkrenn
Copy link
Contributor

dkrenn commented Feb 26, 2012

sage: # Define the generators for the group of symmetries of the Tic-Tac-Toe board.
sage: r = Permutation("(1,7,9,3)(2,4,8,6)")
sage: f = Permutation("(1,3)(4,6)(7,9)")
sage: # Generate the group of symmetries for the Tic-Tac-Toe board.
sage: PermutationGroup([r,f])
Traceback (most recent call last):
...
TypeError: 'int' object is not iterable

Should see

Permutation Group with generators [(1,3)(4,6)(7,9), (1,7,9,3)(2,4,8,6)]

This is the result when run on a server running 'Sage Version 4.6, Release Date: 2010-10-30'.

This was reported on the public bug reports from the notebook interface by warner@clemson.edu on 12/1/2011.

Component: combinatorics

Keywords: permutation group

Author: Mike Hansen

Reviewer: Daniel Krenn

Merged: sage-5.0.beta14

Issue created by migration from https://trac.sagemath.org/ticket/12597

@mwhansen
Copy link
Contributor

Author: Mike Hansen

@dkrenn
Copy link
Contributor Author

dkrenn commented Feb 27, 2012

comment:2

This is a positive review, except for one small thing (and I do not whether that is one or not): Maybe there should be a comment on the test in permgroup.py mentioning the trac-number of this ticket. If you think, that it is ok as it is (without this comment), the you can change the status to positive_review.

@dkrenn
Copy link
Contributor Author

dkrenn commented Feb 27, 2012

Reviewer: Daniel Krenn

@mwhansen
Copy link
Contributor

Attachment: trac_12597.patch.gz

@mwhansen
Copy link
Contributor

comment:4

I've updated the patch and went ahead and marked it as a positive review.

@jdemeyer
Copy link

Merged: sage-5.0.beta14

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants