Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove "Dependencies check" from ppl #12608

Closed
jdemeyer opened this issue Feb 29, 2012 · 8 comments
Closed

Remove "Dependencies check" from ppl #12608

jdemeyer opened this issue Feb 29, 2012 · 8 comments

Comments

@jdemeyer
Copy link

Remove the following block from the PPL spkg:

# Dependencies check
MPIR_VERSION=`cd $SAGE_ROOT/spkg/; ./standard/newest_version mpir`
if [ $? -ne 0 ]; then
    echo "Failed to find mpir.  Please install the mpir spkg"
    exit 1
fi

Although suggested by the developer manual, it doesn't do what is intented (it only checks that the mpir spkg exists, not that it has been installed). It's also not needed, since it's a standard package depending on a standard package.

While I was changing the package anyway: use patch for patching and clean up spkg-install.

spkg: http://boxen.math.washington.edu/home/jdemeyer/spkg/ppl-0.11.2.p1.spkg

See #12609 for fixing the manual.

CC: @vbraun

Component: packages: standard

Author: Jeroen Demeyer

Reviewer: Volker Braun

Merged: sage-5.0.beta7

Issue created by migration from https://trac.sagemath.org/ticket/12608

@jdemeyer

This comment has been minimized.

@jdemeyer

This comment has been minimized.

@jdemeyer
Copy link
Author

Author: Jeroen Demeyer

@jdemeyer

This comment has been minimized.

@jdemeyer
Copy link
Author

jdemeyer commented Mar 2, 2012

Attachment: ppl-0.11.2.p1.diff.gz

Diff for the ppl spkg, for review only

@vbraun
Copy link
Member

vbraun commented Mar 2, 2012

Reviewer: Volker Braun

@vbraun
Copy link
Member

vbraun commented Mar 2, 2012

comment:5

Looks good, thanks for taking care of this.

@jdemeyer
Copy link
Author

jdemeyer commented Mar 5, 2012

Merged: sage-5.0.beta7

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants