Add option "-c" to sage-spkg to run the test-suite

[jhpalmieri]

With the attached patches, running sage -i -c <pkg> or sage -i --check <pkg> will install the package and then run its test suite, regardless of the setting of SAGE_CHECK or SAGE_CHECK_PACKAGES.

Apply

• attachment: trac_12613-root.post12602.patch and attachment: 12613_review.patch to the root repo.
• attachment: trac_12613-doc.patch and attachment: 12613_review_doc.patch to the Sage repo.

Depends on #12479
Depends on #12579
Depends on #12602

CC: @jdemeyer

Component: build

Author: John Palmieri

Reviewer: Jeroen Demeyer

Merged: sage-5.0.beta13

Issue created by migration from https://trac.sagemath.org/ticket/12613

[jhpalmieri]

Attachment: trac_12613-doc.patch.gz

Sage library

[kcrisman]

comment:2

Will this also work with sage -f -c <pkg>? I assume so, just "check"ing.

[kcrisman]

comment:3

Never mind, I should have read the patches first!

[kcrisman]

comment:4

The doc seems correct and appropriately formatted (I hadn't seen :envvar: before, but it's already in the file and I like it!). The only thing I would say needs real review is that it applies and that "override the settings of SAGE_CHECK and SAGE_CHECK_PACKAGES" works as advertised.

[jdemeyer]

comment:5

unset SAGE_CHECK_PACKAGES

wouldn't work since it would make SAGE_CHECK_PACKAGES equal to !python. So better set

SAGE_CHECK_PACKAGES=x

or something.

Also, it conflicts with #12602.

[jhpalmieri]

comment:6

Replying to @jdemeyer:

unset SAGE_CHECK_PACKAGES wouldn't work since it would make SAGE_CHECK_PACKAGES equal to !python.

Good point. Fixed.

Also, it conflicts with #12602.

Well, I didn't list #12602 as a prerequisite ;) I'm attaching two versions of the patch, one which depends on #12602, and one which doesn't. (I don't know if I'll be able to review #12602 any time soon, by the way.)

[jhpalmieri]

Attachment: trac_12613-root.post12602.patch.gz

[jhpalmieri]

Changed dependencies from #12479, #12579 to #12479, #12579, #12602

[jdemeyer]

Reviewer: Jeroen Demeyer

[jdemeyer]

comment:9

John, I added two reviewer patches. If you're happy with my patches, you can set positive review.

[jhpalmieri]

comment:10

Do you think it's clear enough that you can add the options -s or -c to sage -f ...? How about this change instead (modeled after the usage for sage -t):

diff --git a/spkg/bin/sage b/spkg/bin/sage
--- a/spkg/bin/sage
+++ b/spkg/bin/sage
@@ -113,12 +113,17 @@ usage_advanced() {
     ####  |.....................--.|...................................................|
     echo "Installing packages and upgrading:"
     echo "  -experimental       -- list all experimental packages that can be installed"
-    echo "  -f [packages]       -- force build of the given Sage package (even if it is"
-    echo "                         already installed)"
-    echo "  -f -s [packages]    -- like -f but do not delete the spkg/build directories"
-    echo "  -i [packages]       -- install the given Sage packages"
-    echo "                         if no packages given, print a list of all installed"
-    echo "  -i -s [packages]    -- like -i but do not delete the spkg/build directories"
+    echo "  -f [packages]       -- shortcut for -i -f: force build of the given Sage"
+    echo "                         packages."
+    echo "  -i [options] [packages]"
+    echo "                      -- install the given Sage packages (unless they are"
+    echo "                         already installed); if no packages are given, print"
+    echo "                         a list of all installed packages. Options:"
+    echo "                           -c -- run the packages' test suites"
+    echo "                           -f -- force build: install the packages even"
+    echo "                                 if they are already installed"
+    echo "                           -s -- do not delete the spkg/build directories"
+    echo "                                 after a successful build"
     echo "  -optional           -- list all optional packages that can be installed"
     echo "  -standard           -- list all standard packages that can be installed"
    #echo "  -update             -- download latest non-optional Sage packages (do not build them)"

I can provide a patch for this and a similar one for the reference manual if you want me to.

[jdemeyer]

Attachment: 12613_review.patch.gz

[jdemeyer]

Attachment: 12613_review_doc.patch.gz

[jdemeyer]

comment:11

I did those changes, needs_review.

[jhpalmieri]

comment:12

Great, looks good.

[jdemeyer]

Merged: sage-5.0.beta13