Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Follow-up to #4949: don't delete the current working directory #12637

Closed
jhpalmieri opened this issue Mar 6, 2012 · 7 comments
Closed

Follow-up to #4949: don't delete the current working directory #12637

jhpalmieri opened this issue Mar 6, 2012 · 7 comments

Comments

@jhpalmieri
Copy link
Member

On Solaris, running rm -rf DIR fails if DIR is in the path of the current working directory. This happens in sage-spkg, so the temporary build directories $SAGE_BUILD_DIR/$PKG_NAME don't get deleted. Fix this by running cd ... first.

Apply attachment: trac_12637-cd-before-rm.patch to the root repo.

Component: build

Author: John Palmieri

Reviewer: Jeroen Demeyer

Merged: sage-5.0.beta8

Issue created by migration from https://trac.sagemath.org/ticket/12637

@jhpalmieri

This comment has been minimized.

@jdemeyer
Copy link

jdemeyer commented Mar 6, 2012

comment:2

Could you just add a comment like

# On Solaris, the current working directory cannot be deleted,
# so we "cd" out of $SAGE_BUILD_DIR/$PKG_NAME, see #12637.

@jhpalmieri
Copy link
Member Author

comment:3

Done. (Also changed the name of the patch file to match the ticket number.)

@jhpalmieri

This comment has been minimized.

@jhpalmieri
Copy link
Member Author

Attachment: trac_12637-cd-before-rm.patch.gz

root repo

@jdemeyer
Copy link

jdemeyer commented Mar 7, 2012

Reviewer: Jeroen Demeyer

@jdemeyer
Copy link

Merged: sage-5.0.beta8

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants