Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix inconsistencies in the PolyBoRi interface #12656

Closed
alexanderdreyer mannequin opened this issue Mar 12, 2012 · 10 comments
Closed

Fix inconsistencies in the PolyBoRi interface #12656

alexanderdreyer mannequin opened this issue Mar 12, 2012 · 10 comments
Assignees
@alexanderdreyer
Labels
c: algebra p: major / 3 t: bug
Milestone
sage-5.0

Comments

@alexanderdreyer
Copy link
Mannequin

alexanderdreyer mannequin commented Mar 12, 2012

There are some inconsistencies between PolyBoRi's original interface and Sage's Cython-based reimplementation.

There were uncovered by the newly introduced self-testing feature of the PolyBoRi-shell ipbori. Call ipbori -t with #12655 installed to see the issue.

Current patch

Upstream: None of the above - read trac for reasoning.

CC: @sagetrac-PolyBoRi @malb @burcin

Component: algebra

Author: Alexander Dreyer

Reviewer: Martin Albrecht

Merged: sage-5.0.beta9

Issue created by migration from https://trac.sagemath.org/ticket/12656
@alexanderdreyer alexanderdreyer mannequin added this to the sage-5.0 milestone Mar 12, 2012
@alexanderdreyer alexanderdreyer mannequin self-assigned this Mar 12, 2012
@alexanderdreyer
Copy link
Mannequin Author

alexanderdreyer mannequin commented Mar 12, 2012

Cython interface consistent with PolyBoRi's built-in interface

@alexanderdreyer
Copy link
Mannequin Author

alexanderdreyer mannequin commented Mar 12, 2012

comment:1

Attachment: polybori-0.8.x.Trac12656.patch.gz

For sage-5.0.beta7 (with #12655) the patch applies and tests well (make ptestlong) on a SuSE Enterprise 11 AMD64.

@alexanderdreyer

This comment has been minimized.

Sign in to view
@alexanderdreyer
Copy link
Mannequin Author

alexanderdreyer mannequin commented Mar 12, 2012

comment:2

Also works with plain sage-5.0.beta7 (without #12655).

@malb
Copy link
Member

malb commented Mar 14, 2012

comment:3

Patch looks good, applies cleanly and passes doctests.

@malb
Copy link
Member

malb commented Mar 14, 2012

Reviewer: Martin Albrecht

@jdemeyer
Copy link

Fixed weird whitespace, apply only this

@jdemeyer
Copy link

comment:4

Attachment: polybori-0.8.x.Trac12656.2.patch.gz

@jdemeyer

This comment has been minimized.

Sign in to view
@jdemeyer
Copy link

Merged: sage-5.0.beta9

@alexanderdreyer alexanderdreyer mannequin mentioned this issue Apr 8, 2012
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@alexanderdreyer alexanderdreyer

Labels
c: algebra p: major / 3 t: bug
Projects
None yet
Milestone
sage-5.0
Development

No branches or pull requests
2 participants
@malb @jdemeyer