Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Partitions(-1).list() goes into infinte recursion #12663

Closed
mantepse opened this issue Mar 13, 2012 · 10 comments
Closed

Partitions(-1).list() goes into infinte recursion #12663

mantepse opened this issue Mar 13, 2012 · 10 comments

Comments

@mantepse
Copy link
Contributor

Currently Partitions only checks whether its argument is an integer, but iterating through Partitions(-1) fails. It now creates an empty list.

sage: Partitions(-1).list()
[]

Apply attachment: 12663-partitions_iter_fix-ts-rebased.patch

CC: @sdenton4

Component: combinatorics

Keywords: Partitions, corner case, days38

Author: Travis Scrimshaw

Reviewer: Tom Denton

Merged: sage-5.1.beta1

Issue created by migration from https://trac.sagemath.org/ticket/12663

@mantepse

This comment has been minimized.

@mantepse mantepse changed the title Partitions(-1).list() goes intto infinte recursion Partitions(-1).list() goes into infinte recursion Mar 13, 2012
@tscrim

This comment has been minimized.

@tscrim
Copy link
Collaborator

tscrim commented May 9, 2012

Changed author from Martin Rubey to Travis Scrimshaw

@tscrim
Copy link
Collaborator

tscrim commented May 9, 2012

Reviewer: Tom Denton

@jdemeyer jdemeyer modified the milestones: sage-5.0, sage-5.1 May 11, 2012
@jdemeyer
Copy link

comment:6

The commit message of this patch should be changed (using hg qrefresh -e for example):

  1. The "[mq] ..." should not be there.
  2. It's better not to have one long line, line wrapping is recommended. But make sure the first line (displayed by hg log) makes sense just by itself.

@tscrim
Copy link
Collaborator

tscrim commented May 16, 2012

comment:7

Attachment: trac_12663-partitions_iter_fix-ts.patch.gz

Fixed.

@tscrim
Copy link
Collaborator

tscrim commented May 16, 2012

Changed keywords from Partitions, corner case to Partitions, corner case, days38

@jdemeyer
Copy link

Merged: sage-5.1.beta1

@jdemeyer
Copy link

@jdemeyer

This comment has been minimized.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants