Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stopgap for 9505 #12699

Closed
jbalakrishnan opened this issue Mar 19, 2012 · 14 comments
Closed

Stopgap for 9505 #12699

jbalakrishnan opened this issue Mar 19, 2012 · 14 comments

Comments

@jbalakrishnan
Copy link

need to use sage.misc.stopgap instead of sage.misc.misc

CC: @vbraun

Component: symbolics

Keywords: rd2

Reviewer: Travis Scrimshaw

Issue created by migration from https://trac.sagemath.org/ticket/12699

@ohanar
Copy link
Member

ohanar commented Mar 20, 2012

Reviewer: R. Andrew Ohana

@ohanar
Copy link
Member

ohanar commented Mar 20, 2012

Author: Jen Balakrishnan

@ohanar

This comment has been minimized.

@jbalakrishnan
Copy link
Author

comment:4

Updated patch to import from sage.misc.stopgap.

@jbalakrishnan
Copy link
Author

Changed author from Jen Balakrishnan to Jennifer Balakrishnan

@ohanar
Copy link
Member

ohanar commented Mar 22, 2012

comment:6

looks good now

@jdemeyer
Copy link

comment:7

Could you write a proper commit message? "Trac 12692" isn't. You should (briefly) describe what the patch does. There is no need to write the ticket number.

@jbalakrishnan
Copy link
Author

comment:8

Attachment: trac_12699.2.patch.gz

New commit message added.

@jdemeyer
Copy link

comment:9

This causes a doctest failure:

sage -t  -force_lib devel/sage/sage/symbolic/expression.pyx
**********************************************************************
File "/padic/scratch/jdemeyer/merger/sage-5.0.beta12/devel/sage-main/sage/symbolic/expression.pyx", line 4381:
    sage: f.coefficient(1)
Exception raised:
    Traceback (most recent call last):
      File "/padic/scratch/jdemeyer/merger/sage-5.0.beta12/local/bin/ncadoctest.py", line 1231, in run_one_test
        self.run_one_example(test, example, filename, compileflags)
      File "/padic/scratch/jdemeyer/merger/sage-5.0.beta12/local/bin/sagedoctest.py", line 38, in run_one_example
        OrigDocTestRunner.run_one_example(self, test, example, filename, compileflags)
      File "/padic/scratch/jdemeyer/merger/sage-5.0.beta12/local/bin/ncadoctest.py", line 1172, in run_one_example
        compileflags, 1) in test.globs
      File "<doctest __main__.example_102[18]>", line 1, in <module>
        f.coefficient(Integer(1))###line 4381:
    sage: f.coefficient(1)
      File "expression.pyx", line 4388, in sage.symbolic.expression.Expression.coefficient (sage/symbolic/expression.cpp:19387)
        if len(s.variables()) > 1:
      File "element.pyx", line 332, in sage.structure.element.Element.__getattr__ (sage/structure/element.c:2919)
      File "parent.pyx", line 330, in sage.structure.parent.getattr_from_other_class (sage/structure/parent.c:3329)
    AttributeError: 'sage.rings.integer.Integer' object has no attribute 'variables'
#0: simplify_sum(expr='sum(q^k,k,0,inf))
#1: simplify_sum(expr=a*'sum(q^k,k,0,inf))
**********************************************************************

@jdemeyer jdemeyer modified the milestones: sage-5.11, sage-5.12 Aug 13, 2013
@sagetrac-vbraun-spam sagetrac-vbraun-spam mannequin removed this from the sage-6.1 milestone Jan 30, 2014
@sagetrac-vbraun-spam sagetrac-vbraun-spam mannequin added this to the sage-6.2 milestone Jan 30, 2014
@tscrim
Copy link
Collaborator

tscrim commented Mar 5, 2014

comment:13

No longer needed since #9505 is fixed.

@tscrim
Copy link
Collaborator

tscrim commented Mar 5, 2014

Changed author from Jennifer Balakrishnan to none

@tscrim
Copy link
Collaborator

tscrim commented Mar 5, 2014

Changed dependencies from #12691 to none

@tscrim
Copy link
Collaborator

tscrim commented Mar 5, 2014

Changed reviewer from R. Andrew Ohana to none

@tscrim tscrim removed this from the sage-6.2 milestone Mar 5, 2014
@vbraun
Copy link
Member

vbraun commented Mar 5, 2014

Reviewer: Travis Scrimshaw

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants