Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add \NN to standard latex constant, fixes a few glitches in LaTeX/HTML output #12717

Closed
hivert opened this issue Mar 21, 2012 · 20 comments
Closed

Comments

@hivert
Copy link

hivert commented Mar 21, 2012

The patch

  • add \NN for Natural or Non Negative Integer to standard latex constants
  • add sage/misc/html.py to the documentation and fixes a few wrong ReST
    markup in it
  • improve the LaTeX printing of builtin constants.
  • fixes a few broken links in sage/misc/html.py and sage/misc/latex.py

Apply : attachment: trac_12717-latex_builtin_constants-fh.patch

Florent

Component: documentation

Keywords: latex html

Author: Florent Hivert

Reviewer: Nicolas M. Thiéry

Merged: sage-5.0.beta14

Issue created by migration from https://trac.sagemath.org/ticket/12717

@hivert hivert added this to the sage-5.0 milestone Mar 21, 2012
@hivert hivert self-assigned this Mar 21, 2012
@hivert

This comment has been minimized.

@roed314
Copy link
Contributor

roed314 commented Mar 21, 2012

comment:2

Should I delete the 12697 patch?

@hivert
Copy link
Author

hivert commented Mar 21, 2012

comment:3

Replying to @roed314:

Should I delete the 12697 patch?

Yes please !

Florent

@hivert
Copy link
Author

hivert commented Mar 21, 2012

comment:4

Also the patch you uploaded is directly out of an hg server and was not properly exported. Is it a problem for Jeroen ?

Florent

@roed314
Copy link
Contributor

roed314 commented Mar 22, 2012

comment:5

It's probably better if it were exported. I would wait to get this reviewed and then worry about it if you're still not able to upload the patch to this ticket.

@nthiery
Copy link
Contributor

nthiery commented Mar 22, 2012

comment:6

For the record, I went through the patch, and it looks good. But I haven't double checked the code changes to the html class, nor recompiled the documentation or run the tests.

@jdemeyer
Copy link

comment:7

Why cannot you upload the patch???

@hivert
Copy link
Author

hivert commented Mar 27, 2012

comment:8

Replying to @jdemeyer:

Why cannot you upload the patch???

No Idea ! I tried to upload some other patch without problem but on this one the trac server seems to hang. It happens with Firefox, Opera and Konqueror. So this shouldn't be a problem related to the browser.

Florent

@jdemeyer
Copy link

jdemeyer commented Apr 2, 2012

comment:9

It's not a proper HG exported patch, that's probably why Trac refuses it. Create your patch with hg export and try uploading it again.

@hivert
Copy link
Author

hivert commented Apr 2, 2012

comment:10

Replying to @jdemeyer:

It's not a proper HG exported patch, that's probably why Trac refuses it. Create your patch with hg export and try uploading it again.

No this is not the problem: as I said on sage-devel the exported patch is at

http://sage.math.washington.edu/home/wstein/www/home/hivert/trac_12717-latex_builtin_constants-fh.patch

I can't manage to get it on trac.

@hivert

This comment has been minimized.

@jdemeyer
Copy link

jdemeyer commented Apr 2, 2012

comment:12

Replying to @hivert:

I can't manage to get it on trac.

There is something wrong with that file. Try to figure out what.

@hivert
Copy link
Author

hivert commented Apr 2, 2012

comment:13

Attachment: trac_12717-latex_builtin_constants-fh.patch.gz

@hivert

This comment has been minimized.

@hivert
Copy link
Author

hivert commented Apr 2, 2012

comment:14

Replying to @jdemeyer:

There is something wrong with that file. Try to figure out what.

For some reason trac just accepted the exact same file... Whatever !!!

@hivert

This comment has been minimized.

@nthiery
Copy link
Contributor

nthiery commented Apr 2, 2012

Reviewer: Nicolas M. Thiéry

@jdemeyer jdemeyer changed the title Add \NN to standard latex constant, fixes a few glitches in LaTeX/HTML outpu Add \NN to standard latex constant, fixes a few glitches in LaTeX/HTML output Apr 3, 2012
@jdemeyer

This comment has been minimized.

@hivert
Copy link
Author

hivert commented Apr 3, 2012

comment:19

Replying to @jdemeyer:

Thanks for the fix. Concerning the title, it was cut automatically by trac (or so it seems to me). Did something change on trac's config ?

@jdemeyer
Copy link

Merged: sage-5.0.beta14

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants