Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Raise algebras/free_algebra.py coverage to 100% #12749

Closed
sagetrac-JStarx mannequin opened this issue Mar 26, 2012 · 6 comments
Closed

Raise algebras/free_algebra.py coverage to 100% #12749

sagetrac-JStarx mannequin opened this issue Mar 26, 2012 · 6 comments

Comments

@sagetrac-JStarx
Copy link
Mannequin

sagetrac-JStarx mannequin commented Mar 26, 2012

The attached patch adds a doctest to _coerce_map_from_, which was the only function missing one.

Component: doctest coverage

Keywords: FreeAlgebra

Author: Jim Stark

Reviewer: David Loeffler

Merged: sage-5.0.beta12

Issue created by migration from https://trac.sagemath.org/ticket/12749

@sagetrac-JStarx sagetrac-JStarx mannequin added this to the sage-5.0 milestone Mar 26, 2012
@sagetrac-JStarx sagetrac-JStarx mannequin added t: tests labels Mar 26, 2012
@loefflerd
Copy link
Mannequin

loefflerd mannequin commented Mar 26, 2012

comment:3

In the list of things coercing into a free algebra, you have

        398	        - Polynomial rings in the same variables over a base with a coercion 
 	399	          map into self.base_ring() 

This is false: a polynomial ring (in which the variables commute) does not, and should not, coerce into a free algebra (in which they don't). Did you mean "free algebras in the same variables..."?

sage: F = FreeAlgebra(ZZ, 3, 'x,y,z')
sage: G = PolynomialRing(ZZ, 3, 'x,y,z')
sage: F.has_coerce_map_from(G)
False

@loefflerd
Copy link
Mannequin

loefflerd mannequin commented Mar 26, 2012

Work Issues: correct false statement

@loefflerd loefflerd mannequin added s: needs work and removed s: needs review labels Mar 26, 2012
@sagetrac-JStarx
Copy link
Mannequin Author

sagetrac-JStarx mannequin commented Mar 26, 2012

comment:4

Attachment: trac12749.patch.gz

I just copied what was in the comments into the docstring, but you're right it's incorrect. I've fixed the docstring and the comments now.

@sagetrac-JStarx
Copy link
Mannequin Author

sagetrac-JStarx mannequin commented Mar 26, 2012

Changed work issues from correct false statement to none

@loefflerd
Copy link
Mannequin

loefflerd mannequin commented Mar 26, 2012

Reviewer: David Loeffler

@jdemeyer
Copy link

jdemeyer commented Apr 2, 2012

Merged: sage-5.0.beta12

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant