Fix scoping / name look-up issue in PolyBoRi 0.8.0 and support flags from the environment

[alexanderdreyer]

The following was found out here:
http://groups.google.com/group/sage-release/browse_thread/thread/e2a87c73dc1625f2

* PolyBoRi fails to build due to stricter (C++11) scoping / name look-up rules.
    Unfortunately PolyBoRi doesn't honor CXXFLAGS, so I had to use CXX="g++-4.7.0 -fpermissive" to make the spkg build. 

The scoping issue should be fixed here:
https://bitbucket.org/brickenstein/polybori/changeset/43b3931ceed7/raw/

Also, we should support CXXFLAGS and CFLAGS (ANd CPPFLAGS?) in the spkg.

Current spkg

• Install http://boxen.math.washington.edu/home/dreyer/spkg/polybori-0.8.0.p2.spkg

Upstream: Fixed upstream, in a later stable release.

CC: @nexttime @sagetrac-PolyBoRi @malb @burcin

Component: algebra

Keywords: C++11 GCC 4.7.0 CXXFLAGS -fpermissive

Author: Alexander Dreyer

Reviewer: Leif Leonhardy

Merged: sage-5.0.beta12

Issue created by migration from https://trac.sagemath.org/ticket/12750

[alexanderdreyer]

comment:1

There an updates spkg here:
http://boxen.math.washington.edu/home/dreyer/spkg/polybori-0.8.0.p2.spkg

[nexttime]

Changed keywords from none to C++11 GCC 4.7.0 CXXFLAGS -fpermissive

[nexttime]

comment:6

Works as advertised, i.e., builds with GCC 4.7.0 (without -fpermissive) and also honors CXXFLAGS in the C++ compile commands (although I have to admit I haven't checked all of them, just a couple). Also passes its test suite.

I haven't really looked at the new spkg itself though, but I expect it to have no flaws... ;-)

[nexttime]

Reviewer: Leif Leonhardy

[nexttime]

comment:7

Replying to @nexttime:

I haven't really looked at the new spkg itself though, but I expect it to have no flaws... ;-)

Ok, did so. "Global" CFLAGS, CPPFLAGS and CXXFLAGS are properly added now, and upstream patches fixing the name look-up issue get applied.

The last revision isn't tagged yet (which the merge script then will do later), but more importantly, SPKG.txt lacks a new changelog entry.

[nexttime]

Work Issues: Update SPKG.txt.

[alexanderdreyer]

comment:8

I forgot that in the first. I immediately replaced it the spkg, but maybe it was cached somewhere, s.th. you might have to reload it.

The latest entry is as follows:

=== polybori-0.8.0.p2 (Alexander Dreyer, March 26th, 2012) ===
 * Fix scoping/name look-up issue and support flags from the environment

[nexttime]

comment:10

Replying to @alexanderdreyer:

I forgot that in the first. I immediately replaced it the spkg, but maybe it was cached somewhere, s.th. you might have to reload it.

Well, the updated one is nearly 5 hours younger... ;-)

[nexttime]

Changed work issues from Update SPKG.txt. to none

[alexanderdreyer]

comment:11

Replying to @nexttime:

Replying to @alexanderdreyer:

I forgot that in the first. I immediately replaced it the spkg, but maybe it was cached somewhere, s.th. you might have to reload it.

Well, the updated one is nearly 5 hours younger... ;-)

Right, 'immediately' in a philosophical manner ;-) No, sorry I had had trouble connecting to boxen then.

[alexanderdreyer]

comment:12

Replying to @nexttime:

Replying to @alexanderdreyer:

I forgot that in the first. I immediately replaced it the spkg, but maybe it was cached somewhere, s.th. you might have to reload it.

Well, the updated one is nearly 5 hours younger... ;-)

Can you also have a look at #12754 for PolyBoRi 0.8.1?

[jdemeyer]

Changed author from AlexanderDreyer to Alexander Dreyer

[jdemeyer]

Merged: sage-5.0.beta12