Clean up dead links in sage/modular/ documentation

[loefflerd]

Using the sage -docbuild --warn-links command reveals a bunch of broken links in the modular forms reference manual:

<autodoc>:1: WARNING: py:class reference target not found: sage.structure.parent_base.ParentWithBase
<autodoc>:1: WARNING: py:class reference target not found: sage.structure.parent_base.ParentWithBase
<autodoc>:1: WARNING: py:class reference target not found: sage.structure.parent_base.ParentWithBase
<autodoc>:1: WARNING: py:class reference target not found: sage.structure.parent_base.ParentWithBase
/storage/masiao/sage-5.0.beta10/local/lib/python2.7/site-packages/sage/modular/local_comp/smoothchar.py:docstring of sage.modular.local_comp.smoothchar.SmoothCharacterGroupRamifiedQuadratic.change_ring:1: WARNING: py:meth reference target not found: base_extend
/storage/masiao/sage-5.0.beta10/local/lib/python2.7/site-packages/sage/modular/local_comp/smoothchar.py:docstring of sage.modular.local_comp.smoothchar.SmoothCharacterGroupRamifiedQuadratic.ideal:1: WARNING: py:meth reference target not found: sage.rings.number_field.number_field_ideal.idealstar
/storage/masiao/sage-5.0.beta10/local/lib/python2.7/site-packages/sage/modular/local_comp/smoothchar.py:docstring of sage.modular.local_comp.smoothchar.SmoothCharacterGroupRamifiedQuadratic.ideal:1: WARNING: py:meth reference target not found: sage.rings.number_field.number_field_ideal.ideallog
/storage/masiao/sage-5.0.beta10/local/lib/python2.7/site-packages/sage/modular/local_comp/smoothchar.py:docstring of sage.modular.local_comp.smoothchar.SmoothCharacterGroupUnramifiedQuadratic.change_ring:1: WARNING: py:meth reference target not found: base_extend
/storage/masiao/sage-5.0.beta10/local/lib/python2.7/site-packages/sage/modular/local_comp/smoothchar.py:docstring of sage.modular.local_comp.smoothchar.SmoothCharacterGroupUnramifiedQuadratic.ideal:1: WARNING: py:meth reference target not found: sage.rings.number_field.number_field_ideal.idealstar
/storage/masiao/sage-5.0.beta10/local/lib/python2.7/site-packages/sage/modular/local_comp/smoothchar.py:docstring of sage.modular.local_comp.smoothchar.SmoothCharacterGroupUnramifiedQuadratic.ideal:1: WARNING: py:meth reference target not found: sage.rings.number_field.number_field_ideal.ideallog
/storage/masiao/sage-5.0.beta10/local/lib/python2.7/site-packages/sage/modular/modform/cuspidal_submodule.py:docstring of sage.modular.modform.cuspidal_submodule.CuspidalSubmodule.change_ring:1: WARNING: py:meth reference target not found: base_extend
docstring of sage.modular.modform.eis_series_cython.eisenstein_series_poly:1: WARNING: py:class reference target not found: sage.libs.flint.fmpz_poly.Fmpz_poly
<autodoc>:1: WARNING: py:class reference target not found: sage.structure.parent_base.ParentWithBase

Component: modular forms

Author: David Loeffler

Reviewer: Alex Ghitza

Merged: sage-5.0.beta12

Issue created by migration from https://trac.sagemath.org/ticket/12757

[loefflerd]

Attachment: trac_12757-fix_broken_links.patch.gz

Patch against 5.0.beta10

[loefflerd]

comment:1

Here's a patch. To test this, on a clean Sage branch run the commands

sage -docbuild --warn-links reference html
sage -hg qimport https://github.com/sagemath/sage-prod/files/10655225/trac_12757-fix_broken_links.patch.gz 
sage -hg qpush
find devel/sage/sage/modular/ -name "*.py*" | xargs touch
sage -b
sage -docbuild --warn-links reference html

This will make Sphinx rebuild all files in sage/modular (plus one or two others touched by this ticket), and you can verify that they all build without warnings.

[loefflerd]

Author: David Loeffler

[aghitza]

comment:2

The warnings are gone. Looks good to me.

[aghitza]

Reviewer: Alex Ghitza

[loefflerd]

comment:3

Thanks for the review!

[jdemeyer]

Merged: sage-5.0.beta12