Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Root poset should treat type A1 properly #12838

Closed
stumpc5 opened this issue Apr 13, 2012 · 9 comments
Closed

Root poset should treat type A1 properly #12838

stumpc5 opened this issue Apr 13, 2012 · 9 comments

Comments

@stumpc5
Copy link
Contributor

stumpc5 commented Apr 13, 2012

The patch fixes the issue that the one element root poset in type A1 was not returned correctly.

sage: Phi = RootSystem(['A',1]).root_poset(); Phi
Finite poset containing 1 elements
sage: Phi.cover_relations()
[]

I also added the facade option for root posets.

Component: combinatorics

Keywords: root poset

Author: Christian Stump

Reviewer: Frédéric Chapoton

Merged: sage-5.1.beta0

Issue created by migration from https://trac.sagemath.org/ticket/12838

@fchapoton
Copy link
Contributor

Reviewer: Frédéric Chapoton

@fchapoton
Copy link
Contributor

comment:2

In sage/combinat/root_system/root_system.py,

it should be written

- ``restricted`` -- 

(i.e. there are missing backquotes)

Otherwise, it seems ok.

@stumpc5
Copy link
Contributor Author

stumpc5 commented Apr 19, 2012

comment:3

Replying to @fchapoton:

In sage/combinat/root_system/root_system.py,

it should be written

- ``restricted`` -- 

(i.e. there are missing backquotes)

Otherwise, it seems ok.

done.

@jdemeyer
Copy link

jdemeyer commented May 6, 2012

comment:6

This patch needs a commit message and also needs to be rebased to sage-5.0.beta14 (or later).

@jdemeyer
Copy link

jdemeyer commented May 9, 2012

comment:7

ping

@stumpc5
Copy link
Contributor Author

stumpc5 commented May 9, 2012

comment:8

Replying to @jdemeyer:

ping

Sorry for being slow...

I added a commit message -- the patch applies smoothly on 5.0.rc0.

@jdemeyer
Copy link

jdemeyer commented May 9, 2012

Attachment: trac_12838-root_poset_A1-cs.patch.gz

@jdemeyer
Copy link

jdemeyer commented May 9, 2012

comment:9

Not quite smoothly:

applying trac_12838-root_poset_A1-cs.patch
patching file sage/combinat/root_system/root_lattice_realizations.py
Hunk #1 succeeded at 507 with fuzz 2 (offset -34 lines).

Anyway, I rebased it.

@jdemeyer
Copy link

Merged: sage-5.1.beta0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants