Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug in Sage's monodromy pairing on elements of Brandt modules #12866

Closed
adeines mannequin opened this issue Apr 21, 2012 · 18 comments
Closed

Bug in Sage's monodromy pairing on elements of Brandt modules #12866

adeines mannequin opened this issue Apr 21, 2012 · 18 comments

Comments

@adeines
Copy link
Mannequin

adeines mannequin commented Apr 21, 2012

In Magma:

Br:=BrandtModule(2,7);
g:=Br.1-Br.2;
InnerProduct(g,g);
6

In Sage:

Br = BrandtModule(2,7)
g1,g2 = Br.basis()
g = g1-g2
print g1,g2
print g.monodromy_pairing(g)
(1, 0) (0, 1)
2

Component: modular forms

Keywords: Brandt module, monodromy pairing

Author: Aly Deines, Gonzalo Tornaría

Branch: 448cd9d

Reviewer: Frédéric Chapoton

Issue created by migration from https://trac.sagemath.org/ticket/12866

@adeines adeines mannequin added this to the sage-5.11 milestone Apr 21, 2012
@adeines adeines mannequin added c: modular forms labels Apr 21, 2012
@adeines adeines mannequin assigned craigcitro Apr 21, 2012
@jdemeyer jdemeyer modified the milestones: sage-5.11, sage-5.12 Aug 13, 2013
@adeines
Copy link
Mannequin Author

adeines mannequin commented Jan 4, 2014

Branch: u/aly.deines/ticket/12866

@sagetrac-vbraun-spam sagetrac-vbraun-spam mannequin modified the milestones: sage-6.1, sage-6.2 Jan 30, 2014
@sagetrac-vbraun-spam sagetrac-vbraun-spam mannequin modified the milestones: sage-6.2, sage-6.3 May 6, 2014
@sagetrac-vbraun-spam sagetrac-vbraun-spam mannequin modified the milestones: sage-6.3, sage-6.4 Aug 10, 2014
@tornaria
Copy link
Contributor

Changed branch from u/aly.deines/ticket/12866 to u/tornaria/ticket/12866

@tornaria
Copy link
Contributor

Commit: cede6e1

@tornaria
Copy link
Contributor

comment:6

I rebased Aly's patch to sage-6.4.beta1. I added a series of commits to fix a typo in her patch, add some explanation of the computation that is being done, and then an asymptotic improvement so that the monodromy pairing can be computed in O(n) rather than O(n2) ideal computations.


New commits:

2f56770Fixed Brandt module monodromy weights.
1891ad3Fix Aly patch for Brandt module monodromy weights.
1fead1dBrandt modules: extend _ideal_products() method
cede6e1Trac 12866: improve asymptotic of monodromy_weights()

@tornaria
Copy link
Contributor

Author: aly.deines, tornaria

@sagetrac-jakobkroeker
Copy link
Mannequin

sagetrac-jakobkroeker mannequin commented Aug 25, 2015

Stopgaps: todo

@fchapoton
Copy link
Contributor

Changed branch from u/tornaria/ticket/12866 to public/12866

@fchapoton
Copy link
Contributor

Changed commit from cede6e1 to 8cb36d5

@fchapoton
Copy link
Contributor

comment:9

I have made a branch with other changes to the file:

  • many doc enhancements, and problems corrected
  • use of cached_method instead of custom cache
  • other small code changes.

New commits:

fcf022aMerge branch 'u/tornaria/ticket/12866' into 7.1.rc0
8cb36d5trac #12866 general spring cleanup of doc of Brandt modules

@fchapoton fchapoton modified the milestones: sage-6.4, sage-7.1 Mar 14, 2016
@fchapoton
Copy link
Contributor

Changed author from aly.deines, tornaria to Aly Deines, Gonzalo Tornaria

@fchapoton
Copy link
Contributor

Changed stopgaps from todo to none

@fchapoton fchapoton modified the milestones: sage-7.1, sage-7.2 Mar 25, 2016
@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jul 30, 2016

Branch pushed to git repo; I updated commit sha1. New commits:

448cd9dMerge branch 'public/12866' into 7.3.rc0

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jul 30, 2016

Changed commit from 8cb36d5 to 448cd9d

@fchapoton fchapoton modified the milestones: sage-7.2, sage-7.4 Jul 30, 2016
@fchapoton
Copy link
Contributor

Reviewer: Frédéric Chapoton

@fchapoton
Copy link
Contributor

comment:15

I have checked the code of the authors.
My own changes are purely cosmetic, and I have double-checked them.
The bot has given a green light.

Therefore I am going to set this to positive review.

@vbraun
Copy link
Member

vbraun commented Aug 7, 2016

Changed branch from public/12866 to 448cd9d

@fchapoton
Copy link
Contributor

Changed author from Aly Deines, Gonzalo Tornaria to Aly Deines, Gonzalo Tornaría

@fchapoton
Copy link
Contributor

Changed commit from 448cd9d to none

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants