Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

several spkg's don't install if the .hg repos have been deleted #12938

Closed
williamstein opened this issue May 10, 2012 · 17 comments
Closed

several spkg's don't install if the .hg repos have been deleted #12938

williamstein opened this issue May 10, 2012 · 17 comments

Comments

@williamstein
Copy link
Contributor

For security and size purposes, some people delete all the .hg repos from
Sage. This breaks installing precisely four of them: extcode, sage, sage_root, sage_scripts. This ticket fixes all these.

Component: distribution

Keywords: sd40.5

Author: William Stein, Keshav Kini

Reviewer: Marc Mezzarobba

Issue created by migration from https://trac.sagemath.org/ticket/12938

@williamstein
Copy link
Contributor Author

Attachment: trac_12938-sage.patch.gz

apply to the Sage library (in SAGE_ROOT/devel/sage/)

@kini
Copy link
Collaborator

kini commented May 25, 2012

apply to $SAGE_ROOT/data/extcode

@kini
Copy link
Collaborator

kini commented May 25, 2012

Attachment: trac_12938-extcode.patch.gz

apply to $SAGE_LOCAL/bin

@kini
Copy link
Collaborator

kini commented May 25, 2012

Attachment: trac_12938-scripts.patch.gz

Attachment: trac_12938-root.patch.gz

apply to $SAGE_ROOT

@kini
Copy link
Collaborator

kini commented May 25, 2012

comment:1

I guess this should fix everything...

@kini
Copy link
Collaborator

kini commented May 25, 2012

Changed keywords from none to sd40.5

@kini
Copy link
Collaborator

kini commented May 25, 2012

Changed author from William Stein to William Stein, Keshav Kini

@williamstein
Copy link
Contributor Author

Reviewer: William Stein

@williamstein
Copy link
Contributor Author

comment:3

I'm testing this on sage.math by build/testing from scratch with the four .hg repos mentioned above deleted.

@williamstein
Copy link
Contributor Author

comment:4

The sage_scripts part fails:

gcc version 4.6.3 (GCC) 
****************************************************
./spkg-install: line 24: /scratch/wstein/ref/sage-5.0/local/bin//.hg/hgrc: No such file or directory

That this won't work is obvious if you look at spkg-install.

@kini
Copy link
Collaborator

kini commented May 25, 2012

comment:6

I don't really understand what you did. To make this work you will need to do sage -sdist first, then build from that. At what point are the .hg repos deleted?

@williamstein
Copy link
Contributor Author

comment:7

Replying to @kini:

I don't really understand what you did.

  1. Extra sage-5.0.tar
  2. tar xf something.spkg
  3. Apply your patch(es)
  4. Delete .hg directory
  5. sage -pkg something
  6. make

@kini
Copy link
Collaborator

kini commented May 25, 2012

comment:8

OK, so please instead try this:

  1. Have a Sage installation
  2. Apply my patches (and your patch) to the repos in the installation of Sage
  3. Run sage --sdist
  4. Unpack the resulting sage-whatever.tar
  5. Go to spkg/standard
  6. tar xf the four SPKGs
  7. Delete .hg directory
  8. sage -pkg the four SPKGs
  9. make in the root of the extracted Sage source distro

@kini
Copy link
Collaborator

kini commented May 26, 2012

comment:9

Yeah, this needs more work. There is a ton of usage of hg throughout the scripts. Big mess.

@ohanar
Copy link
Member

ohanar commented Jun 18, 2012

comment:10

the extcode spkg should be fixed in #13123.

@jdemeyer jdemeyer modified the milestones: sage-5.11, sage-5.12 Aug 13, 2013
@sagetrac-vbraun-spam sagetrac-vbraun-spam mannequin modified the milestones: sage-6.1, sage-6.2 Jan 30, 2014
@fchapoton
Copy link
Contributor

comment:13

This seems to be a mercurially dead ticket, now that we have switched to git.

@fchapoton fchapoton removed this from the sage-6.2 milestone Mar 4, 2014
@mezzarobba
Copy link
Member

Changed reviewer from William Stein to Marc Mezzarobba

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

7 participants