Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move __len__ and __getitem__ from Parent to FiniteEnumeratedSets #12955

Open
nthiery opened this issue May 17, 2012 · 13 comments
Open

Move __len__ and __getitem__ from Parent to FiniteEnumeratedSets #12955

nthiery opened this issue May 17, 2012 · 13 comments
Assignees
@nthiery
Labels
c: categories p: major / 3 s: needs work t: enhancement

Comments

@nthiery
Copy link
Contributor

nthiery commented May 17, 2012

Title says it all. The point is that with the current implementation prevents categories to override those methods with something more interesting. Alas, the attached patch is not yet ready for consumption since there still remains finite (enumerated) sets in Sage that are not in FiniteSets of FiniteEnumeratedSets (see #12913 and #12957)

In the mean time, #12956 provides a workaround for __getitem__.

Depends on #12957

CC: @sagetrac-sage-combinat @nathanncohen

Component: categories

Branch/Commit: public/12955 @ b6aeeb3

Issue created by migration from https://trac.sagemath.org/ticket/12955
@nthiery nthiery added this to the sage-5.11 milestone May 17, 2012
@nthiery nthiery self-assigned this May 17, 2012
@nthiery
Copy link
Contributor Author

nthiery commented May 17, 2012

Preliminary patch

@nthiery

This comment has been minimized.

Sign in to view
@nthiery
Copy link
Contributor Author

nthiery commented May 17, 2012

Dependencies: #12957

@nthiery
Copy link
Contributor Author

nthiery commented May 17, 2012

comment:1

Attachment: trac_12955-move_getitem_len_out_of_parent-nt.patch.gz

@jdemeyer jdemeyer modified the milestones: sage-5.11, sage-5.12 Aug 13, 2013
@sagetrac-vbraun-spam sagetrac-vbraun-spam mannequin modified the milestones: sage-6.1, sage-6.2 Jan 30, 2014
@sagetrac-vbraun-spam sagetrac-vbraun-spam mannequin modified the milestones: sage-6.2, sage-6.3 May 6, 2014
@sagetrac-vbraun-spam sagetrac-vbraun-spam mannequin modified the milestones: sage-6.3, sage-6.4 Aug 10, 2014
@videlec
Copy link
Contributor

videlec commented May 11, 2015

comment:6

Is there any concrete plan for this 3 year old ticket?

@videlec

This comment has been minimized.

Sign in to view
@videlec
Copy link
Contributor

videlec commented Aug 13, 2015

Changed author from Nicolas M. Thiéry to none

@videlec
Copy link
Contributor

videlec commented Aug 13, 2015

Branch: public/12955

@videlec
Copy link
Contributor

videlec commented Aug 13, 2015

Commit: b6aeeb3

@videlec
Copy link
Contributor

videlec commented Aug 13, 2015

comment:9

Let the patchbot runs to see the amount of work...

New commits:

66d60d2#12955: Move `__len__` and `__getitem__` from Parent to FiniteEnumeratedSets
b6aeeb3Trac 12955: fix polynomial ring creation via R['x']

@videlec
Copy link
Contributor

videlec commented Aug 13, 2015

Changed keywords from days38 to none

@videlec videlec modified the milestones: sage-6.4, sage-6.9 Aug 13, 2015
@videlec
Copy link
Contributor

videlec commented Aug 13, 2015

comment:10

... a lot!

@kwankyu
Copy link
Collaborator

kwankyu commented Jun 29, 2016

comment:11

Please check #20902, related to this ticket.

@mkoeppe mkoeppe removed this from the sage-6.9 milestone Dec 29, 2022
@nthiery nthiery mentioned this issue May 23, 2012
Closed
@mezzarobba mezzarobba mentioned this issue Mar 3, 2014
Open
@kwankyu kwankyu mentioned this issue Nov 7, 2016
Closed
@videlec videlec mentioned this issue Jan 29, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nthiery nthiery

Labels
c: categories p: major / 3 s: needs work t: enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@nthiery @kwankyu @jdemeyer @videlec @mkoeppe