New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix misleading typo in the doc of "cython" #12975
Comments
comment:1
C++ typo fixed. |
comment:2
I attached a new patch which should allow |
comment:3
With your patch, the following still does not work
Hence, one still needs
|
comment:4
My reviewer patch will contain a test such as this:
But with your current patch, one would still need c++, not C++. |
comment:5
Attachment: trac_12975-cython_cpp_pragma.patch.gz New patch attached with same name. This one should do it. :) |
Changed author from Simon King to Simon King, Burcin Erocal |
doc test for Burcin's patch |
This comment has been minimized.
This comment has been minimized.
Reviewer: Simon King |
Changed author from Simon King, Burcin Erocal to Burcin Erocal |
comment:6
Attachment: trac_12975_reviewer.patch.gz I have successfully run the tests in sage/misc with your patch and my reviewer patch. I will wait for a full test run (either by myself or the patchbot) before giving a positive review. Apply trac_12975-cython_cpp_pragma.patch trac_12975_reviewer.patch |
comment:7
make ptest passes, and thus I give it a positive review. |
comment:8
I changed the component into "interfaces" (to cython), since the fix was not just modifying the documentation, after all. |
Merged: sage-5.1.beta1 |
That's misleading, as Cython does only accept
#clang c++
but not#clang C++
. Thank you, Burcin, for pointing that out!Apply
CC: @burcin
Component: interfaces
Author: Burcin Erocal
Reviewer: Simon King
Merged: sage-5.1.beta1
Issue created by migration from https://trac.sagemath.org/ticket/12975
The text was updated successfully, but these errors were encountered: