New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add another doctest to connecting conversion maps #12990
Comments
comment:1
The solution was found by Simon King discussing #12269 |
Author: Simon King, Luis Felipe Tabera Alonso |
comment:3
OK, nevermind attachment: trac_12990.patch. Overlapping time windows! Just go with the first patch. The typo was introduced in #7420, which was merged in 4.3. Apparently changes after 4.7.1 made it so that the example in the ticket activates this code path. |
comment:4
patchbot: apply connecting.patch |
Reviewer: Keshav Kini |
comment:5
Looks good to go. |
comment:6
Looks like like a duplicate of #12919. |
comment:7
Well would you look at that... hmm. Maybe we can keep the doctest from this patch. I've posted a comment on #12919. |
comment:8
Yes, whis is a clear duplicate of #12919, however, I would like to keep also the doctest of this patch, 12919 doctest is a an ad-hoc class for testing the bug. In this patch is a "real-life" situation where the bug is triggered. Should I clear the patch to keep only the doctest and possibli be merged? |
comment:9
Sounds good to me. |
This comment has been minimized.
This comment has been minimized.
Changed reviewer from Keshav Kini to Keshav Kini, Marco Streng |
comment:11
Attachment: connecting.patch.gz |
comment:12
Whoops, forgot about this ticket. Thanks for the positive review, mstreng. |
Merged: sage-5.3.beta2 |
between 4.7.x and 5.x series, the following error was introduced:
This error was fixed in #12919. We propose to add a new test to that fix.
CC: @simon-king-jena
Component: coercion
Author: Simon King, Luis Felipe Tabera Alonso
Reviewer: Keshav Kini, Marco Streng
Merged: sage-5.3.beta2
Issue created by migration from https://trac.sagemath.org/ticket/12990
The text was updated successfully, but these errors were encountered: