dir(RIF) contains duplicates

[saraedum]

Currently, dir(RIF), and probably a few others, contains duplicates:

sage: A = dir(RIF)
sage: B = set(A)
sage: for b in B: A.remove(b)
sage: A
['__doc__', '_sage_src_lines_', 'is_field', 'is_integrally_closed']

The attached patch fixes this problem.

Component: categories

Keywords: beginner sd40.5

Author: Julian Rueth

Reviewer: Mike Hansen

Merged: sage-5.1.beta2

Issue created by migration from https://trac.sagemath.org/ticket/13043

[saraedum]

Changed keywords from sd40.5 to beginner sd40.5

[sagetrac-dsm]

comment:2

I don't seem to see the patch.

[saraedum]

comment:3

Attachment: trac_13043.patch.gz

hehe, you've been too fast. I needed the ticket number first to mention it in the TESTS section. I'm running the full doctests now, after that I'll set it to needs review; but feel free to have a look already.

[saraedum]

Author: Julian Rueth

[roed314]

comment:5

The problem with using the previous approach was that various inputs to unique_merge weren't sorted. Rather than this fix I would prefer fixing dir(self.class) to return a sorted list (currently 'Hom' is first), and to sort self.dict.keys() before passing it to unique_merge (note that all of the duplicated keys in this case come from self.dict.keys(), since dir(cls) is almost sorted).

[mwhansen]

comment:6

Replying to @roed314:

Rather than this fix I would prefer fixing dir(self.class) to return a sorted list (currently 'Hom' is first), and to sort self.dict.keys() before passing it to unique_merge (note that all of the duplicated keys in this case come from self.dict.keys(), since dir(cls) is almost sorted).

Is this just for performance reasons?

[roed314]

comment:7

Yeah. But I didn't mark it as needs work since I wanted another opinion. And since I haven't compared the performance of the two options.

[mwhansen]

comment:8

Is dir() actually used in a performance critical spot? I had just assumed it was basically for introspection.

[roed314]

comment:9

It probably is just for introspection. If someone else wants to give Julian's solution a positive review I'll be totally happy. :-)

[mwhansen]

Reviewer: Mike Hansen

[mwhansen]

comment:10

I looked at it and think that it's fine.

[jdemeyer]

Merged: sage-5.1.beta2