Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

A one letter typo in the documentation for the class DiCyclicGroup #13108

Closed
sagetrac-khalasz mannequin opened this issue Jun 12, 2012 · 8 comments
Closed

A one letter typo in the documentation for the class DiCyclicGroup #13108

sagetrac-khalasz mannequin opened this issue Jun 12, 2012 · 8 comments
Assignees
@wdjoyner
Labels
c: group theory p: minor / 4 t: bug
Milestone
sage-5.1

Comments

@sagetrac-khalasz
Copy link
Mannequin

sagetrac-khalasz mannequin commented Jun 12, 2012

The documentation describing Sage's implementation of Dicylic Groups contains the sentence:

The presentation above means every element can be written as
a^{i} x^{j} with 0<= j<2n, j=0,1.

Here, the second to last occurrence of the letter j should instead be an i.

Apply

  1. attachment: 13108_dicyclicgroupdoctypo.patch

CC: @rbeezer

Component: group theory

Keywords: sd41

Author: Kevin Halasz

Reviewer: Rob Beezer

Merged: sage-5.1.beta6

Issue created by migration from https://trac.sagemath.org/ticket/13108
@sagetrac-khalasz sagetrac-khalasz mannequin added this to the sage-5.0.1 milestone Jun 12, 2012
@sagetrac-khalasz

This comment has been minimized.

Sign in to view
@sagetrac-khalasz
Copy link
Mannequin Author

sagetrac-khalasz mannequin commented Jun 12, 2012

Attachment: 13108_dicyclicgroupdoctypo.patch.gz

@rbeezer
Copy link
Mannequin

rbeezer mannequin commented Jun 12, 2012

Reviewer: Rob Beezer

@rbeezer
Copy link
Mannequin

rbeezer mannequin commented Jun 12, 2012

comment:2

Nice catch. Good first contribution.

Positive review.

@rbeezer rbeezer mannequin added the s: needs review label Jun 12, 2012
@rbeezer

This comment has been minimized.

Sign in to view
@jdemeyer jdemeyer modified the milestones: sage-5.0.1, sage-5.1 Jun 13, 2012
@sagetrac-khalasz
Copy link
Mannequin Author

sagetrac-khalasz mannequin commented Jun 15, 2012

Changed keywords from DiCyclic Group to sd 41

@sagetrac-khalasz
Copy link
Mannequin Author

sagetrac-khalasz mannequin commented Jun 15, 2012

Changed keywords from sd 41 to sd41

@jdemeyer
Copy link

Merged: sage-5.1.beta6

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@wdjoyner wdjoyner

Labels
c: group theory p: minor / 4 t: bug
Projects
None yet
Milestone
sage-5.1
Development

No branches or pull requests
3 participants
@wdjoyner @mwhansen @jdemeyer