Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Sympow on FreeBSD #13144

Closed
kcrisman opened this issue Jun 20, 2012 · 4 comments
Closed

Fix Sympow on FreeBSD #13144

kcrisman opened this issue Jun 20, 2012 · 4 comments

Comments

@kcrisman
Copy link
Member

For the current FreeBSD port, the following patch is necessary. See this sage-devel thread where it was first reported.

--- sympow-1.018.1.p11/src/disk.c-orig 2012-04-19 02:33:51.000000000 +0000
+++ sympow-1.018.1.p11/src/disk.c 2012-04-19 02:34:22.000000000 +0000
@@ -39,7 +39,7 @@
  else if (((sp&3)==0) && CM_CASE) {if (2*ep==sp) S[3]='l'; else S[3]='h';}
  else {if (2*ep==sp) S[3]='L'; else S[3]='H';}
  if (HECKE && dv) {TACKS[which]=malloc(dv*sizeof(QD)); TACKON[which]=dv;}
- else if (dv<=sp/2) TACKON[which]=0;
+ else if (dv<=sp/2) {TACKS[which]=NULL; TACKON[which]=0;}
  else {TACKS[which]=malloc((dv-sp/2)*sizeof(QD)); TACKON[which]=dv-sp/2;}
  S[4]=0; F=fopen("datafiles/param_data","r"); strcpy(U,S);
  if (ANAL_RANK) {if (dv>0) U[0]='A'; else U[0]='m';}

Presumably we would want to only apply this on FreeBSD for now. Needs an spkg.

CC: @peterjeremy

Component: porting: BSD

Reviewer: Stephen Montgomery-Smith

Issue created by migration from https://trac.sagemath.org/ticket/13144

@sagetrac-stephen
Copy link
Mannequin

sagetrac-stephen mannequin commented Jun 20, 2012

comment:1

It is a duplicate of

#12858

I think this patch should be applied to all operating systems. I think it is just a matter of luck that other operating systems were not hit by this bug.

@kcrisman
Copy link
Member Author

Changed author from Stephen Montgomery-Smith to none

@kcrisman
Copy link
Member Author

Reviewer: Stephen Montgomery-Smith

@fchapoton

This comment has been minimized.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants