Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

one test in lattice polytope should be tagged # random #13216

Closed
fchapoton opened this issue Jul 9, 2012 · 8 comments
Closed

one test in lattice polytope should be tagged # random #13216

fchapoton opened this issue Jul 9, 2012 · 8 comments

Comments

@fchapoton
Copy link
Contributor

in the file sage/geometry/lattice_polytope.py

inside the procedure

def _read_nef_x_partitions(data):

the line

        sage: print s

should be replaced by

        sage: print s  # random

because the result contains a timing result, which does not have a fix value. Inside the same file, three other similar tests do already have this tag.

Component: geometry

Keywords: random test, polytope

Author: Frédéric Chapoton

Reviewer: Volker Braun

Merged: sage-5.2.beta1

Issue created by migration from https://trac.sagemath.org/ticket/13216

@fchapoton
Copy link
Contributor Author

Changed work issues from add the random keyword to none

@fchapoton
Copy link
Contributor Author

comment:1

Attachment: trac_13216_random_test-fc.patch.gz

@fchapoton
Copy link
Contributor Author

Author: Frédéric Chapoton

@vbraun
Copy link
Member

vbraun commented Jul 9, 2012

comment:2

How slow is your computer that this test took a measurable (rounded) number of seconds? ;-)

Patch looks good to me!

@vbraun
Copy link
Member

vbraun commented Jul 9, 2012

Reviewer: Volker Braun

@fchapoton
Copy link
Contributor Author

comment:3

Thanks a lot. I had to do that because the patchbot protested on my own ticket #13077, having nothing to do with this one (see the failing test on 5.1.rc1 in http://patchbot.sagemath.org/ticket/13077/)

@jdemeyer
Copy link

jdemeyer commented Jul 9, 2012

comment:4

Long overdue.

@jdemeyer
Copy link

Merged: sage-5.2.beta1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants