New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix is_graded for Posets to use appropriate definition #13222
Comments
Changed reviewer from Anne Schilling and SD40 to Anne Schilling, SD40 |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Changed keywords from sd40 to sd40, posets |
Attachment: trac_13222_is_graded_for_posets.patch.gz |
comment:7
This patch was written and reviewed during the tutorial session lead by Franco Saliola and Anne Schilling during Sage Days 40 with all participants. Positive review. |
comment:9
Positive review if all tests pass on Patchbot (only tested all Tests in /combinat/posets). |
comment:10
Not sure whether "SD40" as reviewer makes much sense, mind if I remove it? |
Changed reviewer from Anne Schilling, SD40 to Anne Schilling |
comment:11
Replying to @jdemeyer:
Sure. We wrote and sort of reviewed the patch during a tutorial at Sage Days 40, so I wanted to give everyone credit for it since many people gave input during the writing and reviewing. Anne |
Merged: sage-5.2.beta1 |
Fix is_graded to use the following definition
a poset is graded if all maximal chains have the same lengths
. See Stanley, EC1.As per this definition, the following poset is not graded:
Beware that not everybody agree on this choice of definition for
ranked / graded. See http://en.wikipedia.org/wiki/Graded_poset.
See also: #12993 and #13223 for a followup!
CC: @sagetrac-sage-combinat
Component: combinatorics
Keywords: sd40, posets
Author: Franco Saliola
Reviewer: Anne Schilling
Merged: sage-5.2.beta1
Issue created by migration from https://trac.sagemath.org/ticket/13222
The text was updated successfully, but these errors were encountered: