Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix is_graded for Posets to use appropriate definition #13222

Closed
anneschilling opened this issue Jul 10, 2012 · 14 comments
Closed

Fix is_graded for Posets to use appropriate definition #13222

anneschilling opened this issue Jul 10, 2012 · 14 comments

Comments

@anneschilling
Copy link

Fix is_graded to use the following definition a poset is graded if all maximal chains have the same lengths. See Stanley, EC1.

As per this definition, the following poset is not graded:

    sage: P = Poset([[1,2,3,4], [[1,2],[2,4],[3,4]]])
    sage: P.is_graded()
    True

Beware that not everybody agree on this choice of definition for
ranked / graded. See http://en.wikipedia.org/wiki/Graded_poset.

See also: #12993 and #13223 for a followup!

CC: @sagetrac-sage-combinat

Component: combinatorics

Keywords: sd40, posets

Author: Franco Saliola

Reviewer: Anne Schilling

Merged: sage-5.2.beta1

Issue created by migration from https://trac.sagemath.org/ticket/13222

@nthiery
Copy link
Contributor

nthiery commented Jul 10, 2012

Changed reviewer from Anne Schilling and SD40 to Anne Schilling, SD40

@nthiery

This comment has been minimized.

@nthiery nthiery changed the title Fixing is_graded for Posets Fix is_graded for Posets to use appropriate definition Jul 10, 2012
@nthiery

This comment has been minimized.

@nthiery

This comment has been minimized.

@nthiery

This comment has been minimized.

@anneschilling

This comment has been minimized.

@anneschilling
Copy link
Author

Changed keywords from sd40 to sd40, posets

@anneschilling
Copy link
Author

Attachment: trac_13222_is_graded_for_posets.patch.gz

@anneschilling
Copy link
Author

comment:7

This patch was written and reviewed during the tutorial session lead by Franco Saliola and Anne Schilling during Sage Days 40 with all participants.

Positive review.

@anneschilling
Copy link
Author

comment:9

Positive review if all tests pass on Patchbot (only tested all Tests in /combinat/posets).

@jdemeyer
Copy link

comment:10

Not sure whether "SD40" as reviewer makes much sense, mind if I remove it?

@jdemeyer
Copy link

Changed reviewer from Anne Schilling, SD40 to Anne Schilling

@jdemeyer jdemeyer modified the milestones: sage-5.3, sage-5.2 Jul 11, 2012
@anneschilling
Copy link
Author

comment:11

Replying to @jdemeyer:

Not sure whether "SD40" as reviewer makes much sense, mind if I remove it?

Sure. We wrote and sort of reviewed the patch during a tutorial at Sage Days 40, so I wanted to give everyone credit for it since many people gave input during the writing and reviewing.

Anne

@jdemeyer
Copy link

Merged: sage-5.2.beta1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants