New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement some new features for partitions (hook_cells, etc.) #13235
Comments
Attachment: trac_13235-hook_cells_for_parition-nu.patch.gz |
This comment has been minimized.
This comment has been minimized.
Changed keywords from partitions to partitions, sd40 |
Reviewer: Andrew Mathas |
comment:3
Everything looks good although I have one comment: if the cell (i,j) is NOT contained in the diagram of the partition then all of these functions currently return an error, however, another possibility would be for the functions The following review patch makes the following minor changes.
This turns out to be significantly faster:
Here, the A similar list compression could be used in the function Finally, there are some doc-test errors in partition.py but these are caused by the changes to depreciation in 5.2, so they are not caused by your patch and I have ignored them. I have left the status as |
Reivew patch (forgot to save pervious version!) |
comment:4
Attachment: trac_13235-review-patch-am.patch.gz Another comment: it would be good to have an analogous |
comment:6
What happened to this? Seems bit-rotten now. Should it be revived? The methods seem useful. |
comment:8
Replying to @darijgr:
Probably the original author lost interest. I think that methods for adding and removing rim hooks would be useful but I am not convinced about the need for the other methods. The problem is that partitions already have a huge number of methods and this makes it hard for the uninitiated to find the methods that they actually need. In addition to sage's global namespace, we probably also need to be careful that we do not over pollute the "method namespace" of the popular classes. Of course, I have some private code that adds still more methods to the partition class and others might think that these methods are equally useless:) In this respect, it's unfortunate that python doesn't allow you to dynamically expand classes so that the user is only exposed to the "really useful" methods by default. (Actually, I have a decorator which makes this feasible, but python purists might argue against my using this in sage:) If you want to revive this patch I'd be happy to review a working version. Andrew |
Implements the following methods for partitions:
CC: @sagetrac-sage-combinat @anneschilling
Component: combinatorics
Keywords: partitions, sd40
Author: NUMATA, Yasuhide
Reviewer: Andrew Mathas
Issue created by migration from https://trac.sagemath.org/ticket/13235
The text was updated successfully, but these errors were encountered: