Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add QQbar._factor_univariate_polynomial() #13275

Closed
saraedum opened this issue Jul 19, 2012 · 7 comments
Closed

Add QQbar._factor_univariate_polynomial() #13275

saraedum opened this issue Jul 19, 2012 · 7 comments
Assignees
@malb
Labels
c: commutative algebra good first issue p: trivial / 5
Milestone
sage-6.2

Comments

@saraedum
Copy link
Member

As a part of #11731, transfer the code which does the factorization over QQbar and AA from sage.rings.polynomial.polynomial_element.Polynomial.factor() to QQbar._factor_univariate_polynomial() and AA._factor_univariate_polynomial() respectively.

Depends on #13274

Component: commutative algebra

Author: Julian Rueth

Branch/Commit: cd6dd44

Reviewer: Peter Bruin

Issue created by migration from https://trac.sagemath.org/ticket/13275
@saraedum saraedum added this to the sage-5.11 milestone Jul 19, 2012
@saraedum
Copy link
Member Author

comment:1

Attachment: trac_13275.patch.gz

@pjbruin
Copy link
Contributor

pjbruin commented Jun 15, 2013

Reviewer: Peter Bruin

@sagetrac-christelle
Copy link
Mannequin

sagetrac-christelle mannequin commented Jul 11, 2013

comment:3

See ticket #13274; doesn't apply correctly to 5.10.

@jdemeyer jdemeyer modified the milestones: sage-5.11, sage-5.12 Aug 13, 2013
@sagetrac-vbraun-spam sagetrac-vbraun-spam mannequin modified the milestones: sage-6.1, sage-6.2 Jan 30, 2014
@pjbruin
Copy link
Contributor

pjbruin commented Feb 22, 2014

Branch: u/pbruin/13275-QQbar_factor_univariate_polynomial

@pjbruin
Copy link
Contributor

pjbruin commented Feb 22, 2014

comment:6

Converted patch to a Git branch, only trivial merge conflicts and whitespace edits. Looks good, all test pass.

New commits:

cd6dd44Added _factor_univariate_polynomial() for QQbar and AA

@pjbruin
Copy link
Contributor

pjbruin commented Feb 22, 2014

Commit: cd6dd44

@vbraun
Copy link
Member

vbraun commented Feb 26, 2014

Changed branch from u/pbruin/13275-QQbar_factor_univariate_polynomial to cd6dd44

@vbraun vbraun closed this as completed in 4bbd1ff Feb 26, 2014
@haikona haikona mannequin mentioned this issue Dec 29, 2022
Open
@saraedum saraedum mentioned this issue Feb 26, 2014
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@malb malb

Labels
c: commutative algebra good first issue p: trivial / 5
Projects
None yet
Milestone
sage-6.2
Development

No branches or pull requests
5 participants
@saraedum @vbraun @malb @jdemeyer @pjbruin