Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

is_unit and __invert__ for Polynomial Quotient Rings #13303

Closed
xcaruso opened this issue Jul 27, 2012 · 11 comments
Closed

is_unit and __invert__ for Polynomial Quotient Rings #13303

xcaruso opened this issue Jul 27, 2012 · 11 comments

Comments

@xcaruso
Copy link
Contributor

xcaruso commented Jul 27, 2012

As it was noticed in ticket #13215, inversion in Polynomial Quotient Rings does not work quite well:

sage: Z16x.<x> = Integers(16)[]
sage: GR.<y> =  Z16x.quotient(x^2 + x + 1)
sage: (2*y)^(-1)
15*y + 15
sage: (2*y)*(2*y)^(-1)
2

I attach a small patch "fixing" this problem: with the patch, a NotImplemetedError is raised when the base ring is not a field.

Apply attachment: trac_13303_invert_polynomial_quotient_rings.patch

CC: @xcaruso

Component: algebra

Keywords: inversion quotient polynomial rings

Author: Xavier Caruso

Reviewer: Travis Scrimshaw

Merged: sage-5.6.beta0

Issue created by migration from https://trac.sagemath.org/ticket/13303

@jdemeyer
Copy link

comment:3

Please fill in your real name as Author.

@xcaruso
Copy link
Contributor Author

xcaruso commented Jul 28, 2012

Author: Xavier Caruso

@burcin
Copy link

burcin commented Oct 8, 2012

Changed dependencies from #13215 to none

@tscrim
Copy link
Collaborator

tscrim commented Nov 23, 2012

comment:6

I've uploaded a review patch which corrects a few documentation issues. If you agree, you can set this to a positive review. Thanks.

@tscrim
Copy link
Collaborator

tscrim commented Nov 23, 2012

Reviewer: Travis Scrimshaw

@tscrim
Copy link
Collaborator

tscrim commented Nov 24, 2012

comment:7

Added a proper commit message to review patch. The trailing whitespace is taken care of in there as well.

@xcaruso

This comment has been minimized.

@xcaruso
Copy link
Contributor Author

xcaruso commented Dec 2, 2012

comment:8

Thanks. I merged your review into my patch.

@xcaruso
Copy link
Contributor Author

xcaruso commented Dec 2, 2012

@tscrim
Copy link
Collaborator

tscrim commented Dec 3, 2012

comment:9

For patchbot:

Apply only: trac_13303_invert_polynomial_quotient_rings.patch

@jdemeyer
Copy link

Merged: sage-5.6.beta0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants