Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

:trac: links are broken #13310

Closed
ppurka opened this issue Jul 31, 2012 · 11 comments
Closed

:trac: links are broken #13310

ppurka opened this issue Jul 31, 2012 · 11 comments

Comments

@ppurka
Copy link
Member

ppurka commented Jul 31, 2012

Two issues:

  1. The use of :trac:`` is broken on the command line. The second link below shouldn't repeat the ticket number of the first one
sage: integral?
<removed earlier text>
       TESTS:

       A symbolic integral from http://trac.sagemath.org/11445 that was
       incorrect in earlier versions of Maxima:

          sage: f = abs(x - 1) + abs(x + 1) - 2*abs(x)
          sage: integrate(f, (x, -Infinity, Infinity))
          2

       Another symbolic integral, from http://trac.sagemath.org/11445,
       that used to return zero incorrectly:

          sage: f = exp(-x) * sinh(sqrt(x))
          sage: integrate(f, x, 0, Infinity)
          1/2*sqrt(pi)*e^(1/4)
  1. reported upstream. The link in the notebook is actually correct (that is I get the correct ticket number in the second URL), but it should open the documentation in a new tab. Otherwise, there is a huge potential of someone losing all their work just because they forgot to shift-click or something.

#13116 fixed trac tickets in docstrings for command line, but I think it wasn't fixed properly. The problem exists at least as far back as sage-5.1.rc0.


Apply attachment: trac_13310-trac.patch

Component: documentation

Keywords: trac keyword

Author: John Palmieri

Reviewer: Punarbasu Purkayastha

Merged: sage-5.3.beta1

Issue created by migration from https://trac.sagemath.org/ticket/13310

@jhpalmieri
Copy link
Member

comment:1

I think that these are two completely separate issue, and deserve completely separate tickets. In fact, issue 2 is really an issue with the notebook, so should be dealt with upstream. I'm attaching a patch for issue 1.

@jhpalmieri
Copy link
Member

Author: John Palmieri

@jhpalmieri
Copy link
Member

comment:2

(By the way, I think that the sagenb issue could be fixed by patching the "sphinxify" function, but it should be done at the sagenb github site, not here.)

@ppurka
Copy link
Member Author

ppurka commented Aug 1, 2012

Reviewer: Punarbasu Purkayastha

@ppurka

This comment has been minimized.

@ppurka
Copy link
Member Author

ppurka commented Aug 1, 2012

comment:3

This works. Thanks. Issue 2 is reported upstream.

@ppurka
Copy link
Member Author

ppurka commented Aug 1, 2012

comment:4

Hmm... the patch does not end with the correct extension, hopefully it is not a problem.

patchbot apply trac_13310-trac.pach

@jhpalmieri

This comment has been minimized.

@jhpalmieri
Copy link
Member

comment:5

It shouldn't be a problem, but just in case...

@jdemeyer
Copy link

comment:6

Attachment: trac_13310-trac.patch.gz

@jdemeyer
Copy link

Merged: sage-5.3.beta1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants