Fix gcc error in pyzmq-2.1.11.p0.spkg #13313

seblabbe · 2012-07-31T15:42:45Z

Here is the new proposed spkg:

http://sage.math.washington.edu/home/slabbe/pyzmq-2.1.11.p1.spkg

As reported on sage-devel here, there is an error when installing the optional package pyzmq #12843 (after its dependency zeromq of course!) on OSX 10.5.8 :

gcc version 4.6.3 (GCC)
****************************************************
running configure
******************************************
Configure: Autodetecting ZMQ settings...
    Custom ZMQ dir:       /Users/slabbe/Applications/sage-5.2.rc0/local
gcc -fno-strict-aliasing -fwrapv -DNDEBUG -g -fwrapv -O3 -Wall -Wstrict-prototypes -arch i386 -I/Users/slabbe/Applications/sage-5.2.rc0/local/include -Izmq/utils -Izmq/core -Izmq/devices -c detect/vers.c -o detect/vers.o
gcc: erreur: i386: No such file or directory
gcc: erreur: unrecognized option ‘-arch’
Fatal:
    Failed to compile ZMQ test program.  Please check to make sure:

    * You have a C compiler installed
    * A development version of Python is installed (including header files)
    * A development version of ZMQ >= 2.1.4 is installed (including header files)
    * If ZMQ is not in a default location, supply the argument --zmq=<path>
    * If you did recently install ZMQ to a default location,
      try rebuilding the ld cache with `sudo ldconfig`
      or specify zmq's location with `--zmq=/usr/local`
   
error: command 'gcc' failed with exit status 1
******************************************

The reason to this is that Sage's gcc spkg does not build a compiler which understands the option -arch of Apple's clone of gcc.

The following patch applied on the spkg fixes the problem :

pyzmq-2.1.11.p1/patches $ cat buildutils.patch
--- src/buildutils.py    2011-12-19 04:21:14.000000000 -0500
+++ src-patched/buildutils.py    2012-07-27 12:01:07.000000000 -0400
@@ -111,13 +111,7 @@
    
     cpreargs = lpreargs = None
     if sys.platform == 'darwin':
-        # use appropriate arch for comiler
-        if platform.architecture()[0]=='32bit':
-            cpreargs = ['-arch','i386']
-            lpreargs = ['-arch', 'i386', '-undefined', 'dynamic_lookup']
-        else:
-            # allow for missing UB arch, since it will still work:
-            lpreargs = ['-undefined', 'dynamic_lookup']
+        lpreargs = ['-undefined', 'dynamic_lookup']
 
     objs = cc.compile([cfile],extra_preargs=cpreargs)
     cc.link_executable(objs, efile, extra_preargs=lpreargs)

Component: packages: optional

Author: Sébastien Labbé

Reviewer: Volker Braun

Issue created by migration from https://trac.sagemath.org/ticket/13313

The text was updated successfully, but these errors were encountered:

dimpase · 2012-07-31T16:23:12Z

comment:1

Could you create a proper patch and upload it as an attachment?

seblabbe · 2012-07-31T16:48:54Z

comment:2

Attachment: buildutils.patch.gz

The patch I just attached should go in pyzmq-2.1.11.p?/patches. I never patch/created a package before. If I am doing something wrong, just tell me.

Sébastien

dimpase · 2012-07-31T17:00:47Z

comment:3

Replying to @seblabbe:

The patch I just attached should go in pyzmq-2.1.11.p?/patches. I never patch/created a package before. If I am doing something wrong, just tell me.

in a nutshell:

rename the package directory pyzmq-2.1.11.p2
put the patch in pyzmq-2.1.11.p2/patches
adjust spkg-install so that this patch is applied (assuming your patch is not a change to Sage's patches to the upstream, but a change of the upstream)
create pyzmq-2.1.11.p2.spkg by running sage -spkg pyzmq-2.1.11.p2/ in the corresponding directory i.e. SAGEROOT/spkg/optional
test it.
upload it somewhere and put a link to it into the ticket description.
mark the ticket as needing review

(I know, sounds like a lot of work :-))

seblabbe · 2012-07-31T18:11:24Z

comment:4

Ok thanks for the cheering. I also read Patching a spkg in the Developper Guide. Here is my first patch to a package (p0 was the most recent version) :

http://sage.math.washington.edu/home/slabbe/pyzmq-2.1.11.p1.spkg

Needs review!

vbraun · 2012-07-31T18:57:05Z

comment:6

Dima, you reported on the mailinglist that installing pyzmq works if you install zmq first. Can you clarify on that? zmq is a requirement, you can't build pyzmq without. I just want tbo be clear that we aren't patching dead code here.

The patch looks good to me, fwiw.

dimpase · 2012-08-01T00:41:46Z

comment:7

Replying to @vbraun:

Dima, you reported on the mailinglist that installing pyzmq works if you install zmq first. Can you clarify on that? zmq is a requirement, you can't build pyzmq without. I just want tbo be clear that we aren't patching dead code here.

Hi Volker,

well, it was a (brain)dead response by me, the code is alive.
Later I was able to reproduce the bug on another installation.

sagetrac-jtremblay · 2012-08-02T14:12:28Z

comment:8

The patch worked for me.

seblabbe · 2012-08-02T18:00:36Z

comment:9

Replying to @sagetrac-jtremblay:

The patch worked for me.

The patch or the spkg ? On which machine ?

sagetrac-jtremblay · 2012-08-02T18:02:25Z

comment:10

The spkg, on OSX 10.7.3 with Sage 5.2 binaries.

seblabbe · 2012-08-02T18:04:53Z

comment:11

Replying to @sagetrac-jtremblay:

The spkg, on OSX 10.7.3 with Sage 5.2 binaries.

And were you obtaining the same problem as me while installing pyzmq-2.1.11.p0.spkg ?

sagetrac-jtremblay · 2012-08-02T19:03:41Z

comment:12

Apparently not, zmq was not installed when I tried installing pyzmq :

Extracting package /Library/sage/spkg/optional/pyzmq-2.1.11.p0.spkg
-rw-r--r--  1 tremblayj  wheel  464755  2 Aug 10:02 /Library/sage/spkg/optional/pyzmq-2.1.11.p0.spkg
Finished extraction
****************************************************
Host system:
Darwin jerometremblayportable.local 11.4.0 Darwin Kernel Version 11.4.0: Mon Apr  9 19:32:15 PDT 2012; root:xnu-1699.26.8~1/RELEASE_X86_64 x86_64
****************************************************
C compiler: gcc
C compiler version:
Using built-in specs.
COLLECT_GCC=gcc
COLLECT_LTO_WRAPPER=/Library/sage/local/bin/../libexec/gcc/x86_64-apple-darwin10.8.0/4.6.3/lto-wrapper
Target: x86_64-apple-darwin10.8.0
Configured with: ../src/configure --prefix=/Users/buildbot/build/sage/bsd-1/bsd_64_binary/build/sage-5.2/local --with-local-prefix=/Users/buildbot/build/sage/bsd-1/bsd_64_binary/build/sage-5.2/local --with-gmp=/Users/buildbot/build/sage/bsd-1/bsd_64_binary/build/sage-5.2/local --with-mpfr=/Users/buildbot/build/sage/bsd-1/bsd_64_binary/build/sage-5.2/local --with-mpc=/Users/buildbot/build/sage/bsd-1/bsd_64_binary/build/sage-5.2/local --with-system-zlib --disable-multilib  
Thread model: posix
gcc version 4.6.3 (GCC) 
****************************************************
running configure
******************************************
Configure: Autodetecting ZMQ settings...
    Custom ZMQ dir:       /Library/sage/local
gcc -fno-strict-aliasing -fwrapv -DNDEBUG -g -fwrapv -O3 -Wall -Wstrict-prototypes -I/Library/sage/local/include -Izmq/utils -Izmq/core -Izmq/devices -c detect/vers.c -o detect/vers.o
detect/vers.c:3:17: fatal error: zmq.h: No such file or directory
compilation terminated.
Fatal: 
    Failed to compile ZMQ test program.  Please check to make sure:

    * You have a C compiler installed
    * A development version of Python is installed (including header files)
    * A development version of ZMQ >= 2.1.4 is installed (including header files)
    * If ZMQ is not in a default location, supply the argument --zmq=<path>
    * If you did recently install ZMQ to a default location, 
      try rebuilding the ld cache with `sudo ldconfig`
      or specify zmq's location with `--zmq=/usr/local`
    
error: command 'gcc' failed with exit status 1

seblabbe · 2013-01-25T10:40:06Z

comment:13

Replying to @sagetrac-jtremblay:

Apparently not, zmq was not installed when I tried installing pyzmq :

Yes, but this was not my question: zeromq needs to be installed before pyzmq.

To summarize:

The pyzmq-2.1.11.p0.spkg is broken on OSX 10.5.8.
The pyzmq-2.1.11.p1.spkg fixes the bug at least for OSX 10.5.8.
The pyzmq-2.1.11.p1.spkg also work on OSX 10.7.3.
And we do not know if pyzmq-2.1.11.p0.spkg was broken on OSX 10.7.3 also (which was my previous question).

#12719 will be merged soon, so it would be nice if this ticket could be reviewed, no?

vbraun · 2013-01-25T11:38:52Z

Reviewer: Volker Braun

vbraun · 2013-01-25T11:38:52Z

Author: Sebastien Labbe

vbraun · 2013-01-25T11:38:52Z

comment:16

Looks good to me.

haraldschilly · 2013-01-25T13:32:43Z

comment:17

spkg is on its way to the servers!

seblabbe · 2013-01-25T16:29:28Z

Changed author from Sebastien Labbe to Sébastien Labbé

seblabbe added this to the sage-5.7 milestone Jul 31, 2012

seblabbe added c: packages: standard labels Jul 31, 2012

This comment has been minimized.

Sign in to view

dimpase added c: packages: optional and removed c: packages: standard labels Jul 31, 2012

seblabbe added the s: needs review label Jul 31, 2012

This comment has been minimized.

Sign in to view

seblabbe changed the title ~~gcc error while installing optionnal package pyzmq-2.1.11.p0~~ Fix gcc error in pyzmq-2.1.11.p0.spkg Jan 25, 2013

This comment has been minimized.

Sign in to view

vbraun added s: positive review and removed s: needs review labels Jan 25, 2013

jdemeyer removed the s: positive review label Jan 26, 2013

jdemeyer closed this as completed Jan 26, 2013

kcrisman mentioned this issue Oct 17, 2015

Let pyzmq build on (really old?) 32-bit OS X machines #17510

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix gcc error in pyzmq-2.1.11.p0.spkg #13313

Fix gcc error in pyzmq-2.1.11.p0.spkg #13313

seblabbe commented Jul 31, 2012

dimpase commented Jul 31, 2012

This comment has been minimized.

seblabbe commented Jul 31, 2012

dimpase commented Jul 31, 2012

seblabbe commented Jul 31, 2012

vbraun commented Jul 31, 2012

dimpase commented Aug 1, 2012

sagetrac-jtremblay mannequin commented Aug 2, 2012

seblabbe commented Aug 2, 2012

sagetrac-jtremblay mannequin commented Aug 2, 2012

seblabbe commented Aug 2, 2012

sagetrac-jtremblay mannequin commented Aug 2, 2012

seblabbe commented Jan 25, 2013

This comment has been minimized.

This comment has been minimized.

vbraun commented Jan 25, 2013

vbraun commented Jan 25, 2013

vbraun commented Jan 25, 2013

haraldschilly commented Jan 25, 2013

seblabbe commented Jan 25, 2013

Fix gcc error in pyzmq-2.1.11.p0.spkg #13313

Fix gcc error in pyzmq-2.1.11.p0.spkg #13313

Comments

seblabbe commented Jul 31, 2012

dimpase commented Jul 31, 2012

This comment has been minimized.

seblabbe commented Jul 31, 2012

dimpase commented Jul 31, 2012

seblabbe commented Jul 31, 2012

vbraun commented Jul 31, 2012

dimpase commented Aug 1, 2012

sagetrac-jtremblay mannequin commented Aug 2, 2012

seblabbe commented Aug 2, 2012

sagetrac-jtremblay mannequin commented Aug 2, 2012

seblabbe commented Aug 2, 2012

sagetrac-jtremblay mannequin commented Aug 2, 2012

seblabbe commented Jan 25, 2013

This comment has been minimized.

This comment has been minimized.

vbraun commented Jan 25, 2013

vbraun commented Jan 25, 2013

vbraun commented Jan 25, 2013

haraldschilly commented Jan 25, 2013

seblabbe commented Jan 25, 2013