Add Holomorph method for Permutation Groups

[sagetrac-khalasz]

Adds a method generating a permutation group's holomorph as a permutation group.
The holomorph of a group is the semidirect product of itself with its automorphism group, where the automorphism group acts canonically. This method has been inserted into categories/groups.py with a NotImplementedError, and then has been overridden in the case of permutation groups.

Apply

1. attachment: 13367_holomorph.patch
2. attachment: trac_13367_review_fc.patch

CC: @rbeezer @benjaminfjones

Component: group theory

Author: Kevin Halasz

Reviewer: Frédéric Chapoton, Benjamin Jones

Merged: sage-5.8.beta1

Issue created by migration from https://trac.sagemath.org/ticket/13367

[vbraun]

comment:3

Typo: semidrirect instead of semidirect.

Another minor nitpick: Please don't add empty lines at the end of docstring or at the beginning of the function body. Python style is to use empty lines as sparingly as possible (see PEP8).

[fchapoton]

comment:4

Typo and doctest corrected in the review patch.

There remains to add doctest for the nonImplemented Method.

[fchapoton]

Reviewer: Frédéric Chapoton

[sagetrac-khalasz]

comment:6

Sorry for forgetting about this patch. It appears that doctests have been added for both nonImplemented methods. Is it now up to me to determine if this patch should receive a positive review?

[benjaminfjones]

comment:7

I've been lurking on this ticket for a while so I figured I could put in some effort :) It looks good now, positive review.

[benjaminfjones]

Changed reviewer from Frédéric Chapoton to Frédéric Chapoton, Benjamin Jones

[jdemeyer]

comment:9

The reviewer patch needs a proper commit message.

[fchapoton]

comment:10

oops, sorry. Here is the new review patch, with added commit message

[jdemeyer]

comment:11

You should replace the commit message, not add to it. I.e. remove the second line

[mq]: trac_13367_review_fc.patch

[fchapoton]

Attachment: trac_13367_review_fc.patch.gz

[fchapoton]

comment:12

ok, ok. Here is a new tentative. Last one hopefully.

[jdemeyer]

Merged: sage-5.8.beta1

[jdemeyer]

Attachment: 13367_holomorph.patch.gz

[jdemeyer]

comment:14

The patch which has actually been merged, rebased to sage-5.8.beta0

[fchapoton]

comment:15

Jeroen, did you merge the first patch only ?

Maybe you mean that you have merged both this patch and the review patch ? Then it would be ok, of course..

[jdemeyer]

comment:16

Yes, both are merged.