Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implementation of the class ClusterSeed #13369

Closed
stumpc5 opened this issue Aug 15, 2012 · 16 comments
Closed

Implementation of the class ClusterSeed #13369

stumpc5 opened this issue Aug 15, 2012 · 16 comments

Comments

@stumpc5
Copy link
Contributor

stumpc5 commented Aug 15, 2012

This class implements cluster seeds for skew-symmetrizable matrices.

The patch contains multiple examples.

sage: S = ClusterSeed(['A',3]); S
A seed for a cluster algebra of rank 3 of type ['A', 3]

Depends on #10538

Component: combinatorics

Keywords: cluster algebra, quiver, days45

Author: Christian Stump, Gregg Musiker

Reviewer: Salvatore Stella

Merged: sage-5.8.beta0

Issue created by migration from https://trac.sagemath.org/ticket/13369

@sagetrac-gmoose05
Copy link
Mannequin

sagetrac-gmoose05 mannequin commented Sep 2, 2012

comment:2
  • trac_13369-cluster_seed-cs-NEW.patch is an exact copy of trac_13369-cluster_seed-cs.patch, except in quiver.py where the change to lines 97-100 now apply to lines 201-204 instead. (Also one typo fixed.)

This was done because trac_13369-cluster_seed-cs.patch no longer applies after recent changes to 10538, although it really was only this four line conflict.

  • More substantially, trac_13369-cluster-seed-gm.patch fixes compatibility issues with recent changes to 10538 and 10527. One can now apply all patches in 10527 in order, then all patches in 10538 in order, then the two patches

trac_13369-cluster_seed-cs-NEW.patch followed by trac_13369-cluster_seed-gm.patch,

and then the rebuilt sage passes all doc tests and appears to work correctly.

  • A more substantial review will be forthcoming.

@sagetrac-gmoose05

This comment has been minimized.

@stumpc5

This comment has been minimized.

@stumpc5 stumpc5 modified the milestones: sage-5.3, sage-5.4 Sep 3, 2012
@stumpc5
Copy link
Contributor Author

stumpc5 commented Sep 3, 2012

comment:5

Replying to @sagetrac-gmoose05:

I just renamed and uploaded the two relevant patches without any changes.

@sagetrac-gmoose05
Copy link
Mannequin

sagetrac-gmoose05 mannequin commented Sep 4, 2012

comment:6

Also, despite the patchbot's inability to apply the patches, it works fine with 5.3.rc1 on my machine (with the 10527 and 10538 patches applied first).

@stumpc5
Copy link
Contributor Author

stumpc5 commented Sep 7, 2012

comment:7

Both patches rebased according to the new lazy import. No other changes.

@Etn40ff
Copy link

Etn40ff commented Jan 27, 2013

Reviewer: Salvatore Stella

@stumpc5
Copy link
Contributor Author

stumpc5 commented Jan 28, 2013

comment:9

Hi,

I updated my first patch (and uploaded Gregg's patch without changes). This resulted in some missing doctests which I then added in yet another patch. We also had some old things in the ClusterVariable class which I removed. If we need that back later, we can do it in another ticket...

Cheers, Christian

@stumpc5
Copy link
Contributor Author

stumpc5 commented Feb 1, 2013

Changed author from Christian Stump to Christian Stump, Gregg Musiker

@stumpc5

This comment has been minimized.

@stumpc5
Copy link
Contributor Author

stumpc5 commented Feb 13, 2013

Attachment: trac_13369_cluster_seed.patch.gz

@sagetrac-gmoose05

This comment has been minimized.

@stumpc5
Copy link
Contributor Author

stumpc5 commented Feb 13, 2013

Attachment: trac_13369-review.patch.gz

@stumpc5
Copy link
Contributor Author

stumpc5 commented Feb 14, 2013

comment:12

Attachment: trac_13369-second_review.patch.gz

@Etn40ff
Copy link

Etn40ff commented Feb 14, 2013

Changed keywords from cluster algebra, quiver to cluster algebra, quiver, days45

@jdemeyer
Copy link

Merged: sage-5.8.beta0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants