New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Minor fix to LiE optional SPKG #13389
Comments
This comment has been minimized.
This comment has been minimized.
comment:3
Also, the use of diff --git a/spkg-install b/spkg-install
--- a/spkg-install
+++ b/spkg-install
@@ -22,7 +22,8 @@ make CC="$CC" || die "Error building LiE
# relocating
cd ..
-sed -i -e "s'$PWD/src'$SAGE_LOCAL/lib/LiE'" src/lie
+sed -e "s'$PWD/src'$SAGE_LOCAL/lib/LiE'" src/lie > src/lie_new
+mv src/lie_new src/lie
rm -rf "$SAGE_LOCAL"/lib/lie # clean up old versions
rm -rf "$SAGE_LOCAL"/bin/lie "$SAGE_LOCAL"/lib/LiE
mv src/lie "$SAGE_LOCAL"/bin/ |
comment:4
I see. This is now fixed too. :) |
diff of latest commit in SPKG, for review purposes |
comment:5
Attachment: lie.diff.gz Sorry, I keep finding more issues. The file Also, the file local/bin/lie should be executable. I guess this was a side effect of changing how sed was used. |
Attachment: trac_13389-path-capitalization.patch.gz apply to $SAGE_ROOT/devel/sage |
comment:6
Fixed, and added a patch to the library. I chose to use the path |
This comment has been minimized.
This comment has been minimized.
comment:7
Patchbot: apply trac_13389-path-capitalization.patch |
comment:8
There is still a doctest failure on some platforms:
If you want to fix it, you can (e.g., test whether |
Reviewer: John Palmieri |
comment:9
Yeah, I think that can be done on a different ticket... |
comment:10
Thanks for the review! |
comment:12
the new optional spkg is uploaded to the server+mirrors |
Merged: sage-5.4.beta0 |
This is a followup to #12983. See jhpalmieri's mail to sage-combinat-devel.
SPKG: http://wstein.org/home/keshav/files/lie-2.2.2.p5.spkg
Also, apply attachment: trac_13389-path-capitalization.patch to
$SAGE_ROOT/devel/sage
.CC: @jhpalmieri
Component: packages: optional
Author: Keshav Kini
Reviewer: John Palmieri
Merged: sage-5.4.beta0
Issue created by migration from https://trac.sagemath.org/ticket/13389
The text was updated successfully, but these errors were encountered: