Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

eval_line in giac interface #13429

Closed
frederichan-IMJPRG opened this issue Sep 4, 2012 · 7 comments
Closed

eval_line in giac interface #13429

frederichan-IMJPRG opened this issue Sep 4, 2012 · 7 comments
Assignees
@williamstein
Labels
c: interfaces p: trivial / 5 t: bug
Milestone
sage-5.13

Comments

@frederichan-IMJPRG
Copy link

eval_line in the giac interface might miss the argument restart_if_needed.

The error can be seen when converting with big matrices to giac.

So I add also a doc test to see it.

NB: The other interfaces like gp,gap,axiom,maple,mathematica got the corresponding change between 4.8 and 5.0

Component: interfaces

Keywords: giac, interface

Author: Frederic Han

Reviewer: Volker Braun

Merged: sage-5.13.beta3

Issue created by migration from https://trac.sagemath.org/ticket/13429
@frederichan-IMJPRG frederichan-IMJPRG added this to the sage-5.11 milestone Sep 4, 2012
@sagetrac-parisse
Copy link
Mannequin

sagetrac-parisse mannequin commented Dec 2, 2012

comment:1

Attachment: giaceval_line.patch.gz

The small change indeed fixes the conversion error.

@jdemeyer jdemeyer modified the milestones: sage-5.11, sage-5.12 Aug 13, 2013
@vbraun
Copy link
Member

vbraun commented Nov 1, 2013

Reviewer: Volker Braun

@vbraun
Copy link
Member

vbraun commented Nov 1, 2013

comment:4

lgtm

@frederichan-IMJPRG
Copy link
Author

comment:5

thanks

@jdemeyer
Copy link

jdemeyer commented Nov 6, 2013

Merged: sage-5.13.beta3

@jdemeyer jdemeyer closed this as completed Nov 6, 2013
@fchapoton
Copy link
Contributor

Changed author from Han Frederic to Frederic Han

@fchapoton
Copy link
Contributor

comment:7

correct name

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@williamstein williamstein

Labels
c: interfaces p: trivial / 5 t: bug
Projects
None yet
Milestone
sage-5.13
Development

No branches or pull requests
5 participants
@vbraun @williamstein @jdemeyer @fchapoton @frederichan-IMJPRG