New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Various small fixes to sage-bdist #13457
Comments
This comment has been minimized.
This comment has been minimized.
comment:3
If you feel like doing a little more: diff --git a/sage-bdist b/sage-bdist
--- a/sage-bdist
+++ b/sage-bdist
@@ -32,10 +32,8 @@ TARGET=sage-"$SAGE_VERSION"-`uname -m`-`
TARGET=`echo $TARGET | sed 's/ //g'` # Remove spaces
TMP="$CUR/tmp/$TARGET"
-mkdir -p "$CUR/tmp"
-
rm -rf "$TMP"
-mkdir "$TMP"
+mkdir -p "$TMP"
# copy sage root repo over:
cd "$SAGE_ROOT"
@@ -72,15 +70,14 @@ if [ -d devel/sage ]; then
ln -sf ../../../../devel/sage/build/sage .
fi
+cd "$SAGE_ROOT"
+
if [ -d devel/sagenb ]; then
echo "Copying Sage Notebook"
cp $CP_OPT -L devel/sagenb "$TMP/devel/sagenb-main"
ln -s sagenb-main "$TMP/devel/sagenb"
fi
-
-cd "$SAGE_ROOT"
-
if [ -d "$PKGDIR" ]; then
echo "Making empty spkg's"
cd "$PKGDIR" The last two changes are actually crucial: you need a I'll try to keep looking at this. |
comment:4
Fixed. Note that the main motivation for this ticket is as prerequisite of #13123. |
comment:5
The new patch looks identical to the old patch. |
comment:6
I accidentally made the fixes to the wrong patch. I'm working on too many tickets at the same time... |
comment:7
Fixed (for real this time). |
comment:8
When I run this on OpenSolaris, I see lots of warning messages like
As far as I can tell, the only consequence of this is that the various symbolic links in local/lib end up with new modification times. If I'm right, we can ignore the warnings. The resulting binary seems to work just fine. What do you think? Also, the verbose flag in |
comment:9
Attachment: 13457_sage_bdist.patch.gz I haven't looked at the OpenSolaris issues, but in any case it's not a regression of this ticket. Agree on removing the |
Reviewer: John Palmieri |
comment:10
Okay, good. |
Merged: sage-5.4.beta2 |
See patch, apply attachment: 13457_sage_bdist.patch to the scripts repository.
Component: scripts
Author: Jeroen Demeyer
Reviewer: John Palmieri
Merged: sage-5.4.beta2
Issue created by migration from https://trac.sagemath.org/ticket/13457
The text was updated successfully, but these errors were encountered: