Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Bases of NCSF and QSym #13505

Closed
sagetrac-chrisjamesberg mannequin opened this issue Sep 18, 2012 · 22 comments
Closed

Implement Bases of NCSF and QSym #13505

sagetrac-chrisjamesberg mannequin opened this issue Sep 18, 2012 · 22 comments

Comments

@sagetrac-chrisjamesberg
Copy link
Mannequin

This patch is an attempt to implement new bases of NCSF and QSym which currently exist on the combinat server. This includes the Monomial basis and Fundamental basis of Tevlin, the dual of the quasisymmetric Schur function introduced by Haglund, Luoto, Mason and van-Willigenburg, the Immaculate basis, introduced by Berg, Bergeron, Saliola, Serrano and Zabrocki. In QSym, it will implement all of the dual bases of NCSF.

Currently the attached patch implements only the Quasisymmetric Schur functions of Haglund, Luoto, Mason, and van-Willigenburg, plus some combinatorics of Composition Tableaux


Apply:

Depends on #14101

CC: @saliola @sagetrac-sage-combinat

Component: combinatorics

Keywords: NCSF QSym

Author: Chris Berg, Jeffrey Ferreira

Reviewer: Travis Scrimshaw

Merged: sage-5.12.beta5

Issue created by migration from https://trac.sagemath.org/ticket/13505

@sagetrac-chrisjamesberg sagetrac-chrisjamesberg mannequin added this to the sage-6.0 milestone Sep 18, 2012
@sagetrac-chrisjamesberg

This comment has been minimized.

@sagetrac-chrisjamesberg sagetrac-chrisjamesberg mannequin self-assigned this Sep 18, 2012
@jeffpferreira
Copy link

comment:3

Chris,

Are you still working on this? I see the patches on the combinat server but don't see a patch here on trac for the quasisymmetric Schur functions. If you'd like to provide a patch of what you have I am happy to review it, add to it, finish it, or whatever.

-Jeff

@jeffpferreira
Copy link

Attachment: trac_13505_quasi_schur.patch.gz

Applies cleanly to sage-5.10.rc1

@jeffpferreira
Copy link

Changed author from Chris Berg to Chris Berg, Jeffrey Ferreira

@jeffpferreira
Copy link

comment:4

I uploaded a patch which implements composition tableaux and quasi symmetric Schur functions. The majority of the code is from the combinat patch Chris mentions in the ticket description, except I changed the class of CompositionTableau to more closely follow sage/combinat/tableau.py. I have also included a backtracker to help speed up iter methods.

I am working on doc strings and doing more tests of the patch, but thought it worthwhile to post the current state considering FPSAC starts next week in Pairs.

-Jeff

@jeffpferreira
Copy link

Attachment: trac_13505_quasi_schur.2.patch.gz

Apply to 5.10

@jeffpferreira
Copy link

comment:5

Uploaded a new patch. Fixed a few edge-case bugs. Doc strings are next. I'll leave as 'needs_work' until I can get those done.

@jeffpferreira
Copy link

Attachment: trac_13505_quasi_schur.3.patch.gz

Apply to 5.11.beta3

@jeffpferreira
Copy link

comment:6

The new patch fixes some bugs and adds lots of documentation. There is nothing else I intend to add, so comments are welcome.

@jeffpferreira

This comment has been minimized.

@darijgr
Copy link
Contributor

darijgr commented Jul 12, 2013

comment:7

A commit message is missing. ("[mq]: port_quasi_schur.patch" is an autogenerated one. You should set a commit message manually by typing hg commit -m "trac #13505: blahblah rather than just hg commit.

On line 347, shouldn't the first > sign be an >= sign?

@jeffpferreira
Copy link

Apply to 5.11.beta3

@jeffpferreira
Copy link

comment:8

Attachment: trac_13505_quasi_schur.4.patch.gz

Thanks for the suggestions. I added a commit message and fixed the line in the documentation you referenced.

Following a suggestion from Chris Berg, I also cleaned up the all.py files so as not to pollute the global namespace.

@tscrim
Copy link
Collaborator

tscrim commented Jul 18, 2013

Attachment: trac_13505-review-ts.patch.gz

@tscrim
Copy link
Collaborator

tscrim commented Jul 18, 2013

Changed reviewer from saliola to Travis Scrimshaw

@tscrim
Copy link
Collaborator

tscrim commented Jul 18, 2013

Dependencies: #14101

@tscrim
Copy link
Collaborator

tscrim commented Jul 18, 2013

comment:9

Hey Jeff,

I've uploaded a review patch which moves the composition tableaux into its own file and does some minor cleanup of the docstrings and removing whitespace. There is a trivial dependency on #14101 in the combinat/all.py. If you're happy with my changes, go ahead and set this to positive review.

Best,

Travis

For patchbot:

Apply: trac_13505_quasi_schur.4.patch​ trac_13505-review-ts.patch​

@tscrim

This comment has been minimized.

@jeffpferreira
Copy link

Attachment: trac_13505_quasi_schur.5.patch.gz

Apply only this one. Apply to 5.11.beta3

@jeffpferreira
Copy link

comment:10

Travis,

I folded your review patch into the main patch. Thanks for your helpful edits. I had been wondering whether to pull the CompositionTableaux classes out and into a new module, thanks for taking care of that. It does make a lot more sense to have them separate.

For patchbot:

Apply: trac_13505_quasi_schur.5.patch​

@jeffpferreira

This comment has been minimized.

@jdemeyer
Copy link

jdemeyer commented Sep 2, 2013

Merged: sage-5.12.beta5

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants