Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Has standard involution function for algebras. #13513

Closed
sagetrac-schisholm mannequin opened this issue Sep 20, 2012 · 6 comments
Closed

Has standard involution function for algebras. #13513

sagetrac-schisholm mannequin opened this issue Sep 20, 2012 · 6 comments
Assignees
@aghitza
Labels
c: algebra p: minor / 4 t: enhancement
Milestone
sage-5.5

Comments

@sagetrac-schisholm
Copy link
Mannequin

sagetrac-schisholm mannequin commented Sep 20, 2012

This algorithm follows John Voight's Alg. 2.10 in Identifying the Matrix Ring. This currently works only for quaternion algebras. The goal is to make it more functional once Algebras have more functionality.

CC: @adeines

Component: algebra

Keywords: Standard Involution

Author: Sarah Chisholm

Reviewer: Aly Deines

Merged: sage-5.5.rc0

Issue created by migration from https://trac.sagemath.org/ticket/13513
@sagetrac-schisholm sagetrac-schisholm mannequin added this to the sage-5.4 milestone Sep 20, 2012
@adeines adeines mannequin added the s: needs review label Sep 25, 2012
@adeines
Copy link
Mannequin

adeines mannequin commented Sep 25, 2012

Reviewer: Aly Deines

@jdemeyer
Copy link

Changed author from schisholm to Sarah Chisholm

@jdemeyer
Copy link

comment:4

Never use

try:
    ...
except:
    ...

(this catching thinks like KeyboardInterrupt and SystemExit which you really don't want).
You should always catch a specific exception, like:

try:
    ...
except AttributeError:
    ...

@sagetrac-schisholm
Copy link
Mannequin Author

sagetrac-schisholm mannequin commented Oct 11, 2012

Version 2

@sagetrac-schisholm
Copy link
Mannequin Author

sagetrac-schisholm mannequin commented Oct 11, 2012

comment:6

Attachment: standard_involution.patch.gz

@jdemeyer jdemeyer modified the milestones: sage-5.4, sage-5.5 Nov 5, 2012
@jdemeyer
Copy link

Merged: sage-5.5.rc0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@aghitza aghitza

Labels
c: algebra p: minor / 4 t: enhancement
Projects
None yet
Milestone
sage-5.5
Development

No branches or pull requests
2 participants
@aghitza @jdemeyer