Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stopgap for 13439 #13537

Closed
saraedum opened this issue Sep 26, 2012 · 7 comments
Closed

Stopgap for 13439 #13537

saraedum opened this issue Sep 26, 2012 · 7 comments

Comments

@saraedum
Copy link
Member

See #13439.

Component: padics

Author: Julian Rueth

Reviewer: Volker Braun

Merged: sage-5.4.rc1

Issue created by migration from https://trac.sagemath.org/ticket/13537

@saraedum saraedum added this to the sage-5.4 milestone Sep 26, 2012
@saraedum
Copy link
Member Author

comment:1

Attachment: trac_13537.patch.gz

Instead of adding a second stopgap warning to the _xgcd method of Polynomial_padic_field_dense, I removed it entirely. It is a protected method, with no doctest which is not called anywhere in sage:

sage: search_src("Polynomial_padic_field_dense")
rings/polynomial/polynomial_element_generic.py:777:class Polynomial_padic_field_dense(Polynomial_padic_generic_dense, Polynomial_generic_dense_field):
rings/polynomial/polynomial_element_generic.py:796:class Polynomial_padic_field_lazy_dense(Polynomial_padic_field_dense):

sage: search_src("Polynomial_padic_field_lazy_dense")
rings/polynomial/polynomial_element_generic.py:787:class Polynomial_padic_field_lazy_dense(Polynomial_padic_field_dense):

@saraedum
Copy link
Member Author

Author: Julian Rueth

@jdemeyer
Copy link

comment:5

Does this really have to be a sage-5.4 blocker?

@vbraun
Copy link
Member

vbraun commented Sep 30, 2012

Reviewer: Volker Braun

@vbraun
Copy link
Member

vbraun commented Sep 30, 2012

comment:6

Looks good to me.

@saraedum
Copy link
Member Author

saraedum commented Oct 3, 2012

comment:7

Replying to @jdemeyer:

Does this really have to be a sage-5.4 blocker?

I followed the developer's guide: "Stopgap tickets should be marked as blockers." Should I have changed the version?

@jdemeyer
Copy link

jdemeyer commented Oct 5, 2012

Merged: sage-5.4.rc1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants