Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AlgebraicExtensionFunctor should not make an assumption on the ordering of parameters #13538

Closed
saraedum opened this issue Sep 26, 2012 · 11 comments

Comments

@saraedum
Copy link
Member

Currently, AlgebraicExtensionFunctor assumes that the .extension() function of a field takes the generators' names as the second argument. This is not always the case:

sage: K = Qp(3,3)
sage: R.<a> = K[]
sage: AEF = sage.categories.pushout.AlgebraicExtensionFunctor([a^2-3], ['a'], [None])
sage: AEF(K)
ValueError: must specify name of generator of extension

The attached patch resolves this problem.

Component: categories

Keywords: sd59

Author: Julian Rueth

Branch/Commit: 717ce89

Reviewer: Peter Bruin

Issue created by migration from https://trac.sagemath.org/ticket/13538

@saraedum
Copy link
Member Author

Attachment: trac_13538.patch.gz

@saraedum

This comment has been minimized.

@jdemeyer jdemeyer modified the milestones: sage-5.11, sage-5.12 Aug 13, 2013
@sagetrac-vbraun-spam sagetrac-vbraun-spam mannequin modified the milestones: sage-6.1, sage-6.2 Jan 30, 2014
@sagetrac-vbraun-spam sagetrac-vbraun-spam mannequin modified the milestones: sage-6.2, sage-6.3 May 6, 2014
@saraedum
Copy link
Member Author

Branch: u/saraedum/ticket/13538

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jun 25, 2014

Branch pushed to git repo; I updated commit sha1. New commits:

76af209Cleaned up docstring for #13538

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jun 25, 2014

Commit: 76af209

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jun 25, 2014

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

717ce89Trac 13538: AlgebraicExtensionFunctor does not make an assumption on the args order

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jun 25, 2014

Changed commit from 76af209 to 717ce89

@saraedum
Copy link
Member Author

Changed keywords from none to sd59

@sagetrac-vbraun-spam sagetrac-vbraun-spam mannequin modified the milestones: sage-6.3, sage-6.4 Aug 10, 2014
@pjbruin
Copy link
Contributor

pjbruin commented May 20, 2015

comment:10

Looks good and the patchbot is happy.

@pjbruin
Copy link
Contributor

pjbruin commented May 20, 2015

Reviewer: Peter Bruin

@vbraun
Copy link
Member

vbraun commented May 20, 2015

Changed branch from u/saraedum/ticket/13538 to 717ce89

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants