Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix bug when taking abs() of exactly known QQbar #1356

Closed
sagetrac-cwitty mannequin opened this issue Dec 2, 2007 · 3 comments
Closed

fix bug when taking abs() of exactly known QQbar #1356

sagetrac-cwitty mannequin opened this issue Dec 2, 2007 · 3 comments
Labels
c: basic arithmetic p: major / 3 t: bug
Milestone
sage-2.8.15

Comments

@sagetrac-cwitty
Copy link
Mannequin

sagetrac-cwitty mannequin commented Dec 2, 2007

The following test fails in 2.8.15.alpha1:

            sage: v = QQbar.zeta(3) + 1
            sage: v.exactify()
            sage: v.abs().minpoly()

but the attached patch fixes it.

Component: basic arithmetic

Issue created by migration from https://trac.sagemath.org/ticket/1356
@sagetrac-cwitty sagetrac-cwitty mannequin added this to the sage-2.8.15 milestone Dec 2, 2007
@rlmill
Copy link
Mannequin

rlmill mannequin commented Dec 2, 2007

comment:1

Attachment: 1356.patch.gz

Now:

sage: v = QQbar.zeta(3) + 1
sage: v.exactify()
sage: v.abs().minpoly()
x - 1

@rlmill rlmill mannequin changed the title fix bug when taking abs() of exactly known QQbar [tested] fix bug when taking abs() of exactly known QQbar Dec 2, 2007
@rlmill rlmill mannequin changed the title [tested] fix bug when taking abs() of exactly known QQbar fix bug when taking abs() of exactly known QQbar Dec 2, 2007
@rlmill rlmill mannequin added the s: positive review label Dec 2, 2007
@williamstein
Copy link
Contributor

comment:3

looks good to me.

@sagetrac-mabshoff
Copy link
Mannequin

sagetrac-mabshoff mannequin commented Dec 2, 2007

comment:4

Merged in 2.8.15.rc0.

@sagetrac-mabshoff sagetrac-mabshoff mannequin closed this as completed Dec 2, 2007
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
c: basic arithmetic p: major / 3 t: bug
Projects
None yet
Milestone
sage-2.8.15
Development

No branches or pull requests
1 participant
@williamstein