Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sage -t --debug trigger on an incorrect doctest in addition to an unexpected error #13610

Closed
roed314 opened this issue Oct 17, 2012 · 12 comments

Comments

@roed314
Copy link
Contributor

roed314 commented Oct 17, 2012

#12415 introduces the ability to drop into a Python debugger when an unexpected error is encountered. I was attempting to have a similar behavior happen when an incorrect result was obtained so that it's easier to figure out what has gone wrong in the doctest. But problems with interrupt handling were delaying the completion of #12415 (already a patchbomb), so I've stripped out that functionality and put it here.

Depends on #14289
Depends on #14290
Depends on #14331
Depends on #13278
Depends on #14370

Component: doctest framework

Author: David Roe

Reviewer: Jeroen Demeyer

Merged: sage-5.9.beta4

Issue created by migration from https://trac.sagemath.org/ticket/13610

@roed314
Copy link
Contributor Author

roed314 commented Mar 18, 2013

Changed dependencies from #12415 to #14289

@roed314
Copy link
Contributor Author

roed314 commented Mar 18, 2013

Changed dependencies from #14289 to #14289, #14290

@roed314
Copy link
Contributor Author

roed314 commented Mar 18, 2013

Attachment: 13610.patch.gz

@roed314
Copy link
Contributor Author

roed314 commented Mar 18, 2013

comment:3

Alright, this works for me on OS X. Needs review.

@jdemeyer
Copy link

jdemeyer commented Apr 1, 2013

Changed dependencies from #14289, #14290 to #14289, #14290, #14331, #13278, #14370

@jdemeyer
Copy link

jdemeyer commented Apr 1, 2013

Reviewer: Jeroen Demeyer

@roed314
Copy link
Contributor Author

roed314 commented Apr 2, 2013

comment:7

Review patch looks good to me.

@jdemeyer
Copy link

jdemeyer commented Apr 2, 2013

Changed work issues from keyboard interrupt, doctesting after exiting the debugger not working correctly to none

@jdemeyer
Copy link

jdemeyer commented Apr 2, 2013

comment:9

Doctest failure in sage/tests/cmdline.py

@jdemeyer
Copy link

jdemeyer commented Apr 3, 2013

comment:10

Attachment: 13610_review.patch.gz

@roed314
Copy link
Contributor Author

roed314 commented Apr 3, 2013

comment:11

Looks good.

@jdemeyer
Copy link

jdemeyer commented Apr 4, 2013

Merged: sage-5.9.beta4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants