Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

implement xgcd for padics #13627

Closed
saraedum opened this issue Oct 19, 2012 · 23 comments
Closed

implement xgcd for padics #13627

saraedum opened this issue Oct 19, 2012 · 23 comments

Comments

@saraedum
Copy link
Member

Currently, there is no xgcd for padic numbers:

sage: R = Zp(3)
sage: R.one().xgcd(R.zero())
AttributeError: 'sage.rings.padics.padic_capped_relative_element.pAdicCappedRelativeElement' object has no attribute 'xgcd'

The attached patch implements it.

Depends on #13626
Depends on #13628

Component: padics

Author: Julian Rueth

Branch/Commit: 11fe763

Reviewer: Travis Scrimshaw

Issue created by migration from https://trac.sagemath.org/ticket/13627

@saraedum saraedum added this to the sage-5.11 milestone Oct 19, 2012
@saraedum
Copy link
Member Author

Changed dependencies from #13626 to #13626, #13628

@saraedum
Copy link
Member Author

Changed dependencies from #13626, #13628 to #13626, #13628, #13539

@jdemeyer
Copy link

comment:3

Attachment: trac_13627.patch.gz

@jdemeyer jdemeyer modified the milestones: sage-5.11, sage-5.12 Aug 13, 2013
@nilesjohnson
Copy link
Mannequin

nilesjohnson mannequin commented Jan 28, 2014

Branch: u/niles/ticket/13627

@nilesjohnson
Copy link
Mannequin

nilesjohnson mannequin commented Jan 28, 2014

comment:5

rebased to sage 6.0 and converted to git branch; no other changes

merges cleanly in local repository in spite of what trac says


New commits:

e3315d8Trac #13626: implemented gcd for padics
c3df981Trac #13441: refactored gcd to not use _gcd calls anymore
aab8e2eMerge branch 'ticket/13441' into ticket/13626
5b6e9c6Trac #13628: refactored xgcd to not use _xgcd calls anymore.
f66e7a2Merge branch 'ticket/13628' into ticket/13627
da9b384Trac #13627: implemented xgcd for padics

@nilesjohnson
Copy link
Mannequin

nilesjohnson mannequin commented Jan 28, 2014

Commit: da9b384

@sagetrac-vbraun-spam sagetrac-vbraun-spam mannequin modified the milestones: sage-6.1, sage-6.2 Jan 30, 2014
@sagetrac-vbraun-spam sagetrac-vbraun-spam mannequin modified the milestones: sage-6.2, sage-6.3 May 6, 2014
@saraedum
Copy link
Member Author

Changed branch from u/niles/ticket/13627 to u/saraedum/ticket/13627

@tscrim
Copy link
Collaborator

tscrim commented Jul 28, 2014

Reviewer: Travis Scrimshaw

@tscrim
Copy link
Collaborator

tscrim commented Jul 28, 2014

Changed branch from u/saraedum/ticket/13627 to u/tscrim/ticket/13627

@tscrim
Copy link
Collaborator

tscrim commented Jul 28, 2014

comment:10

Hey Julian,

Some very minor formatting tweaks. LGTM otherwise, so if you're happy with my changes, you can set this positive review.


New commits:

f29a33fMerge branch 'develop' into ticket/13627
ef34decminor changes in documentation for xgcd of p-adics
2dfb2bbxgcd for p-adics if one of the parameters is zero
700b534Some minor formatting review tweaks for #13627.

@tscrim
Copy link
Collaborator

tscrim commented Jul 28, 2014

Changed commit from da9b384 to 700b534

@saraedum
Copy link
Member Author

Changed branch from u/tscrim/ticket/13627 to u/saraedum/ticket/13627

@saraedum
Copy link
Member Author

Changed commit from 700b534 to d88624c

@saraedum
Copy link
Member Author

comment:12

Thanks. I made a minor fix to one docstring. From my point of view, this can be positive_review now.


New commits:

d88624cminor LaTeX fix xgcd docstring

@tscrim
Copy link
Collaborator

tscrim commented Jul 28, 2014

comment:13

:p whoops. Positive review.

@sagetrac-vbraun-spam sagetrac-vbraun-spam mannequin removed this from the sage-6.3 milestone Aug 10, 2014
@sagetrac-vbraun-spam sagetrac-vbraun-spam mannequin added this to the sage-6.4 milestone Aug 10, 2014
@tscrim
Copy link
Collaborator

tscrim commented Aug 28, 2014

comment:15

Julian, think you can rebase this so Volker can merge it in? Or do you want me to do it?

@saraedum
Copy link
Member Author

saraedum commented Sep 2, 2014

comment:16

I don't have time to do so right now. Feel free to rebase it :)

@tscrim
Copy link
Collaborator

tscrim commented Sep 4, 2014

Changed branch from u/saraedum/ticket/13627 to u/tscrim/13627

@tscrim
Copy link
Collaborator

tscrim commented Sep 4, 2014

Changed commit from d88624c to 11fe763

@tscrim
Copy link
Collaborator

tscrim commented Sep 4, 2014

comment:17

Rebased version.


New commits:

11fe763Merge branch 'u/saraedum/ticket/13627' of trac.sagemath.org:sage into u/tscrim/13627

@vbraun
Copy link
Member

vbraun commented Sep 9, 2014

comment:18

Removing the pre-git dependency for scripting sanity.

@vbraun
Copy link
Member

vbraun commented Sep 9, 2014

Changed dependencies from #13626, #13628, #13539 to #13626, #13628

@vbraun
Copy link
Member

vbraun commented Sep 9, 2014

Changed branch from u/tscrim/13627 to 11fe763

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants