Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More doctests for sage.rings #13685

Closed
tscrim opened this issue Nov 4, 2012 · 16 comments
Closed

More doctests for sage.rings #13685

tscrim opened this issue Nov 4, 2012 · 16 comments

Comments

@tscrim
Copy link
Collaborator

tscrim commented Nov 4, 2012

More doctests for the rest of sage.rings as a followup to #13618. This adds documentation for minor functions in the following files:

  • sage/rings/commutative_algebra.py
  • sage/rings/commutative_ring.py
  • sage/rings/commutative_ring_element.py
  • sage/rings/dedekind_domain.py
  • sage/rings/dedekind_domain_element.py
  • sage/rings/euclidean_domain.py
  • sage/rings/euclidean_domain_element.py
  • sage/rings/field.py
  • sage/rings/field_element.py
  • sage/rings/fraction_field.py
  • sage/rings/fraction_field_element.pyx
  • sage/rings/function_field/constructor.py
  • sage/rings/ideal_monoid.py
  • sage/rings/infinity.py
  • sage/rings/integer_ring.pyx
  • sage/rings/integer_ring_python.py
  • sage/rings/integral_domain.py
  • sage/rings/integral_domain_element.py
  • sage/rings/monomials.py
  • sage/rings/morphism.pyx
  • sage/rings/multi_power_series_ring_element.py
  • sage/rings/noncommutative_ideals.pyx
  • sage/rings/principal_ideal_domain.py
  • sage/rings/principal_ideal_domain_element.py
  • sage/rings/quotient_ring.py
  • sage/rings/residue_field.pyx
  • sage/rings/ring.pyx

Most of these files were a few functions short of 100% doctest coverage. This patch also goes through and cleans up some of the documentation in these files as well.

Depends on #13618
Depends on #14040

Component: doctest coverage

Author: Travis Scrimshaw

Reviewer: Volker Braun

Merged: sage-5.9.beta2

Issue created by migration from https://trac.sagemath.org/ticket/13685

@tscrim tscrim added this to the sage-5.7 milestone Nov 4, 2012
@tscrim tscrim self-assigned this Nov 4, 2012
@tscrim

This comment has been minimized.

@tscrim
Copy link
Collaborator Author

tscrim commented Nov 26, 2012

Changed dependencies from #12496 to none

@tscrim
Copy link
Collaborator Author

tscrim commented Nov 26, 2012

comment:2

Rebased to 5.5.rc0

@vbraun
Copy link
Member

vbraun commented Feb 17, 2013

Dependencies: #13618

@vbraun
Copy link
Member

vbraun commented Feb 17, 2013

Reviewer: Volker Braun

@vbraun
Copy link
Member

vbraun commented Feb 19, 2013

comment:4

Looks good to me.

@tscrim
Copy link
Collaborator Author

tscrim commented Feb 19, 2013

comment:6

Thank you for reviewing this,

Travis

@vbraun
Copy link
Member

vbraun commented Feb 25, 2013

comment:7

Needs to be rebased for sage-5.8.beta1, I get

Hunk #77 succeeded at 2051 with fuzz 2 (offset -1 lines).

(we don't like fuzz > 1)

@tscrim
Copy link
Collaborator Author

tscrim commented Feb 25, 2013

comment:8

I'll build 5.8.beta1 over tonight and post the updated patch tomorrow.

@tscrim
Copy link
Collaborator Author

tscrim commented Feb 25, 2013

Changed dependencies from #13618 to #13618 #14040

@tscrim
Copy link
Collaborator Author

tscrim commented Feb 25, 2013

comment:9

And I'll also rebase over #14040.

@jdemeyer
Copy link

comment:10

In fact, better to wait for sage-5.8.beta2 as there are more patches to rings with positive review.

@tscrim
Copy link
Collaborator Author

tscrim commented Feb 26, 2013

comment:11

Replying to @jdemeyer:

In fact, better to wait for sage-5.8.beta2 as there are more patches to rings with positive review.

Will do.

@tscrim
Copy link
Collaborator Author

tscrim commented Mar 27, 2013

Rebased to 5.9.beta1

@tscrim
Copy link
Collaborator Author

tscrim commented Mar 27, 2013

comment:12

Attachment: trac_13685-misc_rings_doc-ts.patch.gz

Rebased to 5.9.beta1.

@jdemeyer
Copy link

Merged: sage-5.9.beta2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants