Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wrong function tested in interface/r.py #13686

Closed
kiwifb opened this issue Nov 5, 2012 · 6 comments
Closed

wrong function tested in interface/r.py #13686

kiwifb opened this issue Nov 5, 2012 · 6 comments

Comments

@kiwifb
Copy link
Member

kiwifb commented Nov 5, 2012

Stumbled upon that while analizing sage-on-gentoo test failures. In r.py there are two functions r.version and r_version. But they have the same doctest...

def r_version():
"""
Return the R version.

EXAMPLES::

    sage: r.version()
    ((2, 14, 0), 'R version 2.14.0 (2011-10-31)')
"""
return r.version()

Sure r_version returns r.version but r_version should be tested not r.version again surely.

CC: @kcrisman

Component: interfaces

Author: Frédéric Chapoton

Reviewer: Nathann Cohen

Merged: sage-5.12.beta5

Issue created by migration from https://trac.sagemath.org/ticket/13686

@fchapoton
Copy link
Contributor

Attachment: trac_13686_r_version_cleanup.patch.gz

@fchapoton
Copy link
Contributor

comment:2

done, needs review

@fchapoton
Copy link
Contributor

Author: Frédéric Chapoton

@nathanncohen
Copy link
Mannequin

nathanncohen mannequin commented Aug 29, 2013

comment:4

I don't know if it makes any sense to have those two functions available, nor to have r_version exported into the global namespace, but this patch still makes sense :-P

Nathann

@nathanncohen
Copy link
Mannequin

nathanncohen mannequin commented Aug 29, 2013

Reviewer: Nathann Cohen

@jdemeyer
Copy link

jdemeyer commented Sep 2, 2013

Merged: sage-5.12.beta5

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants