Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix path in SAGE_ROOT/spkg/README.txt #13702

Closed
pipedream opened this issue Nov 12, 2012 · 13 comments
Closed

Fix path in SAGE_ROOT/spkg/README.txt #13702

pipedream opened this issue Nov 12, 2012 · 13 comments

Comments

@pipedream
Copy link

SAGE_ROOT/spkg/README.txt refers to SAGE_ROOT/sage/doc/output/html/en/developer/index.html but the path should be SAGE_ROOT/devel/sage/doc/output/html/en/developer/index.html

Apply attachment: trac_13702.patch to the root repository.

Component: documentation

Author: Jan Groenewald

Reviewer: Karl-Dieter Crisman

Merged: sage-5.5.rc1

Issue created by migration from https://trac.sagemath.org/ticket/13702

@pipedream

This comment has been minimized.

@pipedream
Copy link
Author

comment:1

Attachment: README.txt.patch.gz

@kcrisman
Copy link
Member

comment:2

You are right, and this fix is okay. The patch is not a standard one, though, so I'm uploading that. Please make sure it applies and does what you want, then switch to positive review.

@kcrisman
Copy link
Member

Author: Jan Groenewald

@kcrisman
Copy link
Member

Reviewer: Karl-Dieter Crisman

@kcrisman
Copy link
Member

comment:3

You can also manually edit the author to be you and upload that patch :-)

@kcrisman
Copy link
Member

Attachment: trac_13702.patch.gz

@kcrisman
Copy link
Member

comment:4

Let's do this thing. Jan, I made you be the author of the patch, since you are.

@pipedream
Copy link
Author

comment:5

Thanks Karl,
Somehow I missed these comments in the last few weeks and only saw it now.
The patch looks good. How can I produce the standard patches?
Regards,
Jan

@kcrisman
Copy link
Member

comment:6

Patchbot, apply trac_13702.patch to the root repository. (Hopefully that will work.)

Jan, you can go into SAGE_ROOT and make your changes, then do

./sage -hg ci
<it should show your changes, then dump you into an editor to produce a commit message>
./sage -hg export tip > /path/to/filename.patch

or you can use hg_root to do things in this repository.

@kcrisman

This comment has been minimized.

@pipedream
Copy link
Author

comment:7

Thanks, I think the only difference was that I used hg instead of sage -hg. I will check the next time I export a patch.

@jdemeyer
Copy link

Merged: sage-5.5.rc1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants